-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes to follow orders NIP proposal #584
Conversation
We were publishing all the movements on nostr but this could be used to deanonymize users, so now we are working only with those status on the specs nostr-protocol/nips#1331
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In-progress
event is published 2 times
In a buy order it is published when:
- the seller takes the order and goes to
Waiting-payment
- the buyer puts the invoice and goes to
Active
In a sales order it is published when:
- the buyer takes the order and goes to
Waiting-buyer-invoice
- the buyer puts the invoice and goes to
Waiting-payment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
success
event is published twice when an admin settles the order (when they cancel the order it works fine)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cuando un admin hace /checkorder
y la orden no está en disputa aparece Status previo a disputa:
pero eso solo debería salir cuando está en disputa
creo que esto está fuera del alcance de este review 😃 |
We were publishing all the movements on nostr but this could be used to deanonymize users, so now we are working only with those status on the specs
nostr-protocol/nips#1331