Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes to follow orders NIP proposal #584

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

grunch
Copy link
Member

@grunch grunch commented Sep 2, 2024

We were publishing all the movements on nostr but this could be used to deanonymize users, so now we are working only with those status on the specs

nostr-protocol/nips#1331

We were publishing all the movements on nostr but this could
be used to deanonymize users, so now we are working only with
those status on the specs

nostr-protocol/nips#1331
@grunch grunch requested a review from Catrya September 2, 2024 21:07
Copy link
Member

@Catrya Catrya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In-progress event is published 2 times

In a buy order it is published when:

  • the seller takes the order and goes to Waiting-payment
  • the buyer puts the invoice and goes to Active

In a sales order it is published when:

  • the buyer takes the order and goes to Waiting-buyer-invoice
  • the buyer puts the invoice and goes to Waiting-payment

Copy link
Member

@Catrya Catrya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

success event is published twice when an admin settles the order (when they cancel the order it works fine)

Copy link
Member

@Catrya Catrya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cuando un admin hace /checkorder y la orden no está en disputa aparece Status previo a disputa: pero eso solo debería salir cuando está en disputa

@grunch
Copy link
Member Author

grunch commented Sep 3, 2024

cuando un admin hace /checkorder y la orden no está en disputa aparece Status previo a disputa: pero eso solo debería salir cuando está en disputa

creo que esto está fuera del alcance de este review 😃

@grunch grunch merged commit dbf81d7 into main Oct 18, 2024
6 checks passed
@grunch grunch deleted the publish-on-nostr-only-basic-order-status branch October 18, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants