Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert ln to TS (6th commit of PR435) #541

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

Mersho
Copy link
Contributor

@Mersho Mersho commented Jul 6, 2024

No description provided.

ln/resubscribe_invoices.ts Outdated Show resolved Hide resolved
@Mersho Mersho force-pushed the ConvertJsToTs-ln branch from d32f95d to 9c3038b Compare July 6, 2024 11:48
@grunch
Copy link
Member

grunch commented Jul 11, 2024

After testing I'm seeing a lot of messages like this one

[2024-07-11T11:09:01.224-03:00] error: All promises were rejected AggregateError: All promises were rejected

Any ideas what could generate them?

@Mersho
Copy link
Contributor Author

Mersho commented Jul 13, 2024

Any ideas what could generate them?

Hey @grunch , sorry for the delay. I couldn't reproduce the error, but I did some digging around and I think this error is related to:

Promise.any()

Here are my references and what I found out:

If all the promises are rejected, promise will be rejected with the error “AggregateError: All promises were rejected”

This is the only place Promise.any() is called:

https://github.com/lnp2pBot/bot/blob/main/bot/modules/nostr/index.js#L27

@knocte
Copy link
Contributor

knocte commented Jul 14, 2024

@grunch can you test with nostr disabled? this way we would confirm that this problem comes from that part of the code instead of from this PR

@grunch
Copy link
Member

grunch commented Jul 15, 2024

@grunch can you test with nostr disabled? this way we would confirm that this problem comes from that part of the code instead of from this PR

That's kinda weird, I can't reproduce the log error again, I'll be testing more today and if it didn't happen again I'll merge this PR

@knocte
Copy link
Contributor

knocte commented Jul 25, 2024

How did the testing go?

@grunch grunch merged commit 3166fe5 into lnp2pBot:main Jul 25, 2024
4 checks passed
grunch added a commit that referenced this pull request Jul 25, 2024
grunch added a commit that referenced this pull request Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants