Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

show Time rem only when status is PENDING #530

Merged
merged 4 commits into from
May 19, 2024
Merged

show Time rem only when status is PENDING #530

merged 4 commits into from
May 19, 2024

Conversation

johan-naizu
Copy link
Contributor

Fixes #529

@knocte
Copy link
Contributor

knocte commented May 18, 2024

Why so much code duplication?

@johan-naizu @Aki-works
Code cleaned
19f6aac 
Co-authored-by: Aki <[email protected]>
@johan-naizu
Copy link
Contributor Author

My bad. Should be fine now

@knocte
Copy link
Contributor

knocte commented May 18, 2024

utACK

grunch
grunch requested changes May 19, 2024
View reviewed changes
Copy link
Member

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! can you please run npm run format and push changes? we are using prettier, alternative you can use it on your code editor with some kind of plugin

@johan-naizu
Copy link
Contributor Author

Is that good?

@johan-naizu johan-naizu requested a review from grunch May 19, 2024 18:56
@johan-naizu johan-naizu requested a review from grunch May 19, 2024 19:16
grunch
grunch approved these changes May 19, 2024
View reviewed changes
Copy link
Member

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks 😃

@grunch grunch mentioned this pull request May 19, 2024
Closed
@grunch grunch merged commit 3612c14 into lnp2pBot:main May 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grunch grunch grunch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Only show time remaining on /listorders when status is PENDING
3 participants
@johan-naizu @knocte @grunch