Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: upgrade Ubuntu to 24.04 #524

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

knocte
Copy link
Contributor

@knocte knocte commented May 15, 2024

GitHubActions' runner image for 'ubuntu-latest' is still running old LTS 22.04, but we can instead use the 'container:' attribute to use a docker image in order to use the new Ubuntu LTS 24.04.

This is the most sensible move especially considering that we have changed CI recently to run on new NodeJS 18.x by default (Ubuntu 22.04's default NodeJS version is much older than v18).

NOTE: MongoDB service start had to be reworked in this commit to make it still work in this new distro version.

GitHubActions' runner image for 'ubuntu-latest' is still running
old LTS 22.04, but we can instead use the 'container:' attribute
to use a docker image in order to use the new Ubuntu LTS 24.04.

This is the most sensible move especially considering that we
have changed CI recently to run on new NodeJS 18.x by default
(Ubuntu 22.04's default NodeJS version is much older than v18).

NOTE: MongoDB service start had to be reworked in this commit to
make it still work in this new distro version.
Copy link
Member

@grunch grunch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job @knocte

@grunch grunch merged commit ccc909e into lnp2pBot:main May 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants