Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commented tests #494

Closed
grunch opened this issue Apr 12, 2024 · 0 comments · Fixed by #503
Closed

Fix commented tests #494

grunch opened this issue Apr 12, 2024 · 0 comments · Fixed by #503
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@grunch
Copy link
Member

grunch commented Apr 12, 2024

At some point tests started to fail, we need to review them and fix

commented tests are in /tests/bot_tests.js
@grunch grunch added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 12, 2024
knocte added a commit to knocte/lnp2pBot that referenced this issue Apr 20, 2024
@knocte
tests: reenable some tests
4a783c4 
They were giving compiler errors in CI, but now they work
(maybe because of the upgrade to Node in [1]?).

[1] 439d043

Fixes lnp2pBot#494
@knocte knocte mentioned this issue Apr 20, 2024
Merged
grunch pushed a commit that referenced this issue Apr 22, 2024
@knocte
tests: reenable some tests (#503)
16b7522 
They were giving compiler errors in CI, but now they work
(maybe because of the upgrade to Node in [1]?).

[1] 439d043

Fixes #494
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

tests: reenable some tests knocte/lnp2pBot
1 participant
@grunch