Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop implicit build support #6

Closed
ncoghlan opened this issue Oct 11, 2024 · 0 comments · Fixed by #48
Closed

Drop implicit build support #6

ncoghlan opened this issue Oct 11, 2024 · 0 comments · Fixed by #48
Labels
Affects: Command Line Affects the command line interface Affects: Compatibility Changes with compatibility implications Affects: Python API Affects the public Python API of the project Category: Maintainability Proposed improvement to project maintainability

Comments

@ncoghlan
Copy link
Collaborator

ncoghlan commented Oct 11, 2024

The implicit build support isn't a good idea.

If external wheel builds are needed, it's much better to have a dedicated process for making those, and supply the results to venvstacks via the local wheel directory support, rather than having venvstacks create them implicitly and rely on pip and uv caching to carry them forward to future builds.

The "local wheel directory" approach also allows for full from-source stack builds via https://github.com/python-wheel-build/fromager, even when a full-fledged internal package hosting server isn't available.

@ncoghlan ncoghlan transferred this issue from another repository Oct 18, 2024
@ncoghlan ncoghlan added Affects: Python API Affects the public Python API of the project Category: Maintainability Proposed improvement to project maintainability Affects: Compatibility Changes with compatibility implications Affects: Command Line Affects the command line interface labels Oct 20, 2024
ncoghlan added a commit that referenced this issue Oct 28, 2024
The implicit build support adds a lot of complexity,
while also being in inherently bad idea (the local
wheel directory support is a much better approach).

Closes #6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Command Line Affects the command line interface Affects: Compatibility Changes with compatibility implications Affects: Python API Affects the public Python API of the project Category: Maintainability Proposed improvement to project maintainability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant