Fix Jetbrains link when using Firefox #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The builtin JB web server doesn't work for Firefox, I think this is the reason: JakeChampion/fetch#310 (comment)
|
Hi @ekatz-quotient, thanks for this PR. As mentioned in #21, adding this permission doesn't seem to solve the issue, and currently I don't know how to solve this, I need to investigate. Did you try on your side with the new permission to see if it's working ? |
|
Answered in #21 |
|
As this permission is required only on Firefox, I don't want to add it on Chrome because it will impact existing users by asking them to accept new permissions. I added a commit to add the permission only on Firefox ;) |
|
@lmichelin Tested, works :) |
|
As explained in #21, it's now working on my side 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The builtin JB web server doesn't work for Firefox, I think this is the reason:
JakeChampion/fetch#310 (comment)