Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Codium : https://vscodium.com #11

Merged
merged 8 commits into from
Sep 27, 2020
Merged

Add support for Codium : https://vscodium.com #11

merged 8 commits into from
Sep 27, 2020

Conversation

subins2000
Copy link
Contributor

@subins2000 subins2000 commented Sep 26, 2020 •
edited
Loading

VSCodium

I hope these changes are enough to add VSCodium. The icons will be the same as VSCode.

@lmichelin
Copy link
Owner

lmichelin commented Sep 27, 2020 •
edited
Loading

Thanks @subins2000 for your contribution 😉

I made some updates to your PR:

  • add specific icons for VSCodium
  • update link to make it work (codium:// -> vscodium://)
  • update readme

I just published v1.1.6 to Chrome Web Store and Firefox Addons.

@lmichelin lmichelin merged commit 9a7407a into lmichelin:master Sep 27, 2020
@subins2000
Copy link
Contributor Author

Thank you @lmichelin for fixing it and merging. The update has reached Firefox, just tried out and it works good! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmichelin lmichelin lmichelin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@subins2000 @lmichelin