Skip to content

Tweaks to Topology Manager docs PR #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sftim
Copy link

@sftim sftim commented Aug 8, 2019

@lmdaly here are some suggestions for kubernetes#15716

Feel free to cherry-pick or revise

@sftim sftim changed the title Tweaks to Topology Management docs PR Tweaks to Topology Manager docs PR Aug 8, 2019
@lmdaly lmdaly force-pushed the topology-management-1.16 branch from 4b592a7 to de1c06f Compare August 15, 2019 12:38
Copy link
Owner

@lmdaly lmdaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks overall good, thanks for the changes!
Couple of small suggestions and I can merge PR (might need a rebase I just pushed some changes)


If you have enabled the `TopologyManager`
[feature gate](/docs/reference/command-line-tools-reference/feature-gates/) then
the kubelet can pay attention to topology hints.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe something like "the kubelet can use topology hints to when making resource assignment decisions"

@@ -397,4 +397,8 @@ The design documents for
[node affinity](https://git.k8s.io/community/contributors/design-proposals/scheduling/nodeaffinity.md)
and for [inter-pod affinity/anti-affinity](https://git.k8s.io/community/contributors/design-proposals/scheduling/podaffinity.md) contain extra background information about these features.

Once a Pod is assigned to a Node, the kubelet runs the Pod and allocates node-local resources.
The [topology manager](/docs/tasks/administer-cluster/topology-manager/) takes part in node-level
scheduling decisions.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: takes part in node-level resource allocation decisions?

@@ -107,7 +107,7 @@ kube-scheduler has a default set of scheduling policies.
volumes should be attached, and whether that's over a configured limit.

- `CheckNodeMemoryPressure`: If a Node is reporting memory pressure, and there's no
configured exception, the Pod won't be scheduled there.
configured Gxception, the Pod won't be scheduled there.
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this change is not meant to be in here :)

@sftim sftim force-pushed the lmdaly_topology-management-1.16_tweaks branch from 62e2ac3 to 8b4b2a5 Compare August 16, 2019 07:48
- Add inbound hyperlinks to Topology Manager task
- Add whatsnext to Topology Manager task
- Mention Node topology in concepts pages
@sftim sftim force-pushed the lmdaly_topology-management-1.16_tweaks branch from 8b4b2a5 to a1c3422 Compare August 16, 2019 07:51
@sftim
Copy link
Author

sftim commented Aug 16, 2019

Tweaked; rebased; squashed; pushed

Copy link
Owner

@lmdaly lmdaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@lmdaly lmdaly merged commit 46ddf05 into lmdaly:topology-management-1.16 Aug 16, 2019
@sftim sftim deleted the lmdaly_topology-management-1.16_tweaks branch August 16, 2019 09:51
@lmdaly
Copy link
Owner

lmdaly commented Aug 16, 2019

Tweaked; rebased; squashed; pushed

Thanks @sftim. Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants