Support async scheduling for prefill transitions - #24
Closed
lmcafee-nvidia wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Lawrence McAfee <lmcafee@nvidia.com>
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Architecture
The engine treats admission draining as a generic async scheduling transition. When new work is ready while an async forward is pending, the controller consumes and resolves that pending result without launching a successor forward. The next engine iteration can then admit the waiting request without mixing two forwards into one controller step.
For non-chunked prefill, the controller resolves the completed prompt forward, prepares the surviving requests for decode, and launches the next forward through the same async scheduling machinery used by steady-state decode. Request compaction follows the legacy row-movement order so request-local sampling state remains attached to the same logical requests.