-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stylelint: Extend order config with new blocks and properties #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1 task
literat
force-pushed
the
dependencies/stylelint-16.x
branch
from
August 7, 2024 12:30
228e047
to
8ffc8d6
Compare
literat
force-pushed
the
feat/stylelint-extend-order
branch
from
August 16, 2024 13:06
61b9406
to
6319062
Compare
adamkudrna
reviewed
Aug 20, 2024
literat
force-pushed
the
feat/stylelint-extend-order
branch
from
August 21, 2024 09:28
6319062
to
01ab0d8
Compare
literat
force-pushed
the
feat/stylelint-extend-order
branch
from
August 21, 2024 10:48
6449dbf
to
7724804
Compare
- `accent-color` - `backdrop-filter` - `backface-visibility` - `background-blend-mode` - `border-spacing` - `box-decoration-break` - `caret-color` - `color-scheme`, `color-interpolation` - `column-fill`, `column-span` - `contain` (including all long-hand variants) - `container` (including all long-hand variants) - `counter-set` - `direction` - `empty-cells` - `font-size-adjust`, `font-variant-*`, `font-feature-settings`, `font-stretch`, `font-synthesis` (including all long-hand variants), `font-kerning`, `font-optical-sizing`, `font-palette` - `image-orientation`, `image-rendering` - `inset` (including all long-hand variants), - `justify-items` - `list-style-image` - `mask` (including all long-hand variants), `mask-border` (including all long-hand variants), `mask-type` - `mix-blend-mode` - `outline-*` - `overflow-anchor` - `overscroll-behavior` (including all long-hand variants). - `paint-order`, - `perspective`, `perspective-origin` - `place-content`, `place-items`, `place-self` - `quotes` - `scrollbar-*` - `table-layout` - `text-align-last`, `text-indent`, `text-decoration-skip-ink`, `text-underline-*`, `text-rendering`, `text-wrap` (including all long-hand variants) - `touch-action`, - `transform-box`, `transform-style`, individual transforms: `translate`, `rotate`, `scale`, - `transition-behavior` - `white-space-collapse` - `word-spacing` The key is roughly like this: all properties from MDN that are standard, widely supported, non-experimental, not specific for non-western languages, and not designed for paged media. https://developer.mozilla.org/en-US/docs/Web/CSS
literat
force-pushed
the
feat/stylelint-extend-order
branch
2 times, most recently
from
August 27, 2024 07:39
899bd37
to
880078f
Compare
adamkudrna
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the config in Spirit and it works as expected 👍🏻.
literat
force-pushed
the
feat/stylelint-extend-order
branch
from
September 10, 2024 17:52
880078f
to
56e5f45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on visionappscz/stylelint-config#60 and
The
order
config enforces a consistent order of content in your declaration blocks.:Based on visionappscz/stylelint-config#61
Add more properties to check their order
Properties added (sorted alphabetically):
accent-color
backdrop-filter
backface-visibility
background-blend-mode
border-spacing
box-decoration-break
caret-color
color-scheme
,color-interpolation
column-fill
,column-span
contain
(including all long-hand variants)container
(including all long-hand variants)counter-set
direction
empty-cells
font-size-adjust
,font-variant-*
,font-feature-settings
,font-stretch
,font-synthesis
(including all long-hand variants),font-kerning
,font-optical-sizing
,font-palette
image-orientation
,image-rendering
inset
(including all long-hand variants),justify-items
list-style-image
mask
(including all long-hand variants),mask-border
(including all long-hand variants),mask-type
mix-blend-mode
outline-*
overflow-anchor
overscroll-behavior
(including all long-hand variants).paint-order
,perspective
,perspective-origin
place-content
,place-items
,place-self
quotes
scrollbar-*
table-layout
text-align-last
,text-indent
,text-decoration-skip-ink
,text-underline-*
,text-rendering
,text-wrap
(including all long-hand variants)touch-action
,transform-box
,transform-style
, individual transforms:translate
,rotate
,scale
,transition-behavior
white-space-collapse
word-spacing
The key is roughly like this: all properties from MDN that are standard, widely supported, non-experimental, not specific for non-western languages, and not designed for paged media.
https://developer.mozilla.org/en-US/docs/Web/CSS