Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Style Control to Chatbot Arena Leaderboard 🔥 #3495

Merged
merged 8 commits into from
Aug 27, 2024
Merged

Conversation

CodingWithTim
Copy link
Collaborator

@CodingWithTim CodingWithTim commented Aug 26, 2024

Why are these changes needed?

Related issue number (if applicable)

Checks

  • I've run format.sh to lint the changes in this PR.
  • I've included any doc changes needed.
  • I've made sure the relevant tests are passing (if applicable).

Copy link
Member

@infwinston infwinston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some quick comments, thanks @CodingWithTim ! we might want to add an option in the argument so we can easily switch to use style control. wdyt?

fastchat/serve/monitor/add_markdown_info.py Outdated Show resolved Hide resolved
fastchat/serve/monitor/add_markdown_info.py Outdated Show resolved Hide resolved
fastchat/serve/monitor/elo_analysis.py Outdated Show resolved Hide resolved
Copy link
Member

@infwinston infwinston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

additional comments based on our offline discussion

fastchat/serve/monitor/add_markdown_info.py Outdated Show resolved Hide resolved
fastchat/serve/monitor/elo_analysis.py Outdated Show resolved Hide resolved
Copy link
Member

@infwinston infwinston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @CodingWithTim !

fastchat/serve/monitor/dev.ipynb Outdated Show resolved Hide resolved
fastchat/serve/monitor/elo_analysis.py Outdated Show resolved Hide resolved
fastchat/serve/monitor/elo_analysis.py Show resolved Hide resolved
@CodingWithTim CodingWithTim merged commit 05b9305 into main Aug 27, 2024
2 checks passed
infwinston pushed a commit that referenced this pull request Oct 6, 2024
Co-authored-by: CodingWithTim <tim@inst-builder-debian-12-build-build-4zqb5.us-central1-a.c.gce-image-builder.internal>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants