Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor model and conversation template registration #1008

Merged
merged 14 commits into from
May 8, 2023
Merged

Conversation

merrymercy
Copy link
Member

@merrymercy merrymercy commented May 8, 2023

  • Refactor model registration. Now adding a new model only needs adding two self-contained code blocks without using "if": a conversation template and a model adapter.
  • API changes
old new
from fastchat.conversation import get_default_conv_template from fastchat import get_conversation_template
from fastchat.serve.inference import load_model, add_model_args from fastchat import load_model, add_model_args

see also the diff for fastchat/serve/huggingface_api.py

  • Other minor improvements

@merrymercy merrymercy merged commit 68d1fdc into main May 8, 2023
@merrymercy merrymercy deleted the model branch May 8, 2023 03:52
@merrymercy merrymercy changed the title Refactor model registration Refactor model and conversation template registration May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants