PR for llvm/llvm-project#54560 #185
Conversation
|
The API compatibility check on this manual cherry-pick failed because @yxsamliu renamed |
Yes, we need to maintain the ABI in the release branch. |
kernels in anonymous name space needs to have unique name to avoid duplicate symbols. Fixes: llvm#54560 Reviewed by: Artem Belevich Differential Revision: https://reviews.llvm.org/D123353 (cherry picked from commit 4ea1d43)
This patch is a continuation of https://reviews.llvm.org/D123353. Not only kernels in anonymous namespace, but also template kernels with template arguments in anonymous namespace need to be externalized. To be more generic, this patch checks the linkage of a kernel assuming the kernel does not have __global__ attribute. If the linkage is internal then clang will externalize it. This patch also fixes the postfix for externalized symbol since nvptx does not allow '.' in symbol name. Reviewed by: Artem Belevich Differential Revision: https://reviews.llvm.org/D124189 Fixes: llvm#54560 (cherry picked from commit 04fb816)
|
@tstellar, I've updated the branch accordingly. GitHub says I need "a maintainer to approve running workflows" -- could you please do that? I expect all tests should pass this time. #187 is a duplicate of my pull request, opened by @yxsamliu. It still has the ABI incompatibility and can thus probably be closed. |
4 participants
resolves llvm#54560