Skip to content

[FMV][AArch64] Fix UPASS when "SSBS not fully self-synchronizing". #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
labrinea merged 3 commits into from
Oct 1, 2024
Merged

[FMV][AArch64] Fix UPASS when "SSBS not fully self-synchronizing". #167

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d2a74ce
[FMV][AArch64] Fix UPASS when "SSBS not fully self-synchronizing".
labrinea Sep 30, 2024
122b97c
Changes from last revision:
labrinea Sep 30, 2024
80eefce
Changes from last revision:
labrinea Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions SingleSource/UnitTests/AArch64/acle-fmv-features.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#include <sys/sysctl.h>
#endif

static bool safe_try_feature(bool (*try_feature)(void));
static bool safe_try_feature(bool (*try_feature)(void), bool is_default);

static bool any_fails = false;

Expand All @@ -27,7 +27,7 @@ static bool any_fails = false;
static void check_##FN_NAME_SUFFIX(void) { \
printf("%s\n", #FMV_FEATURE); \
fflush(stdout); \
if (!safe_try_feature(try_##FN_NAME_SUFFIX)) { \
if (!safe_try_feature(try_##FN_NAME_SUFFIX, false)) { \
printf("\tFAIL\n"); \
any_fails = true; \
} \
Expand All @@ -36,7 +36,7 @@ static bool any_fails = false;
static void check_##FN_NAME_SUFFIX(void) { \
printf("%s\n", #FMV_FEATURE); \
fflush(stdout); \
if (safe_try_feature(try_##FN_NAME_SUFFIX)) { \
if (safe_try_feature(try_##FN_NAME_SUFFIX, true)) { \
printf("\tUPASS\n"); \
any_fails = true; \
} \
Expand Down Expand Up @@ -363,15 +363,23 @@ CHECK(mops, mops, mops, {
);
})

static bool safe_try_feature(bool (*try_feature)(void)) {
bool (*whitelist[])(void) = { try_ssbs2 };

static bool safe_try_feature(bool (*try_feature)(void), bool is_default) {
int child = fork();
if (child) {
int exit_status = -1;
if (child != waitpid(child, &exit_status, 0))
return false;
return exit_status == 0;
} else {
exit(try_feature() ? 0 : 1);
bool found = false;
for (int i = 0, e = sizeof(whitelist) / sizeof(whitelist[0]);
i != e && !found; ++i)
if (try_feature == whitelist[i])
found = true;
bool is_exempt = is_default && found;
exit(try_feature() && !is_exempt ? EXIT_SUCCESS : EXIT_FAILURE);
}
}

Expand Down