[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros by yronglin · Pull Request #90574 · llvm/llvm-project

yronglin · 2024-04-30T09:20:05Z

This PR implement P3034R1 Module Declarations Shouldn’t be Macros, and refactor the convoluted state machines in module name lexical analysis.

Signed-off-by: yronglin <yronglin777@gmail.com>

llvmbot · 2024-04-30T09:20:39Z

@llvm/pr-subscribers-clang-modules

@llvm/pr-subscribers-clang

Author: None (yronglin)

Changes

This PR implement P3034R1 Module Declarations Shouldn’t be Macros

Full diff: https://github.com/llvm/llvm-project/pull/90574.diff

9 Files Affected:

(modified) clang/docs/ReleaseNotes.rst (+2)
(modified) clang/include/clang/Basic/DiagnosticParseKinds.td (+2)
(modified) clang/lib/Parse/Parser.cpp (+7)
(added) clang/test/CXX/cpp/cpp.module/p1.cppm (+13)
(added) clang/test/CXX/cpp/cpp.module/version.h (+8)
(modified) clang/test/CXX/module/basic/basic.link/module-declaration.cpp (+20-15)
(modified) clang/test/CXX/module/dcl.dcl/dcl.module/dcl.module.import/p1.cppm (+2-2)
(modified) clang/test/SemaCXX/modules.cppm (+4)
(modified) clang/www/cxx_status.html (+1-1)

diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index 1abc00a25f1f42..40c6bd63e9948f 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -153,6 +153,8 @@ C++2c Feature Support
 
 - Implemented `P2748R5 Disallow Binding a Returned Glvalue to a Temporary <https://wg21.link/P2748R5>`_.
 
+- Implemented `P3034R1 Module Declarations Shouldn’t be Macros <https://wg21.link/P3034R1>`_.
+
 Resolutions to C++ Defect Reports
 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
 - Substitute template parameter pack, when it is not explicitly specified
diff --git a/clang/include/clang/Basic/DiagnosticParseKinds.td b/clang/include/clang/Basic/DiagnosticParseKinds.td
index fdffb35ea0d955..0d4b526ec6d15a 100644
--- a/clang/include/clang/Basic/DiagnosticParseKinds.td
+++ b/clang/include/clang/Basic/DiagnosticParseKinds.td
@@ -1671,6 +1671,8 @@ def err_unexpected_module_decl : Error<
   "module declaration can only appear at the top level">;
 def err_module_expected_ident : Error<
   "expected a module name after '%select{module|import}0'">;
+def err_module_decl_cannot_be_macros : Error<
+  "module declaration cannot be a macro">;
 def err_attribute_not_module_attr : Error<
   "%0 attribute cannot be applied to a module">;
 def err_keyword_not_module_attr : Error<
diff --git a/clang/lib/Parse/Parser.cpp b/clang/lib/Parse/Parser.cpp
index adcbe5858bc78e..ef66348a83125c 100644
--- a/clang/lib/Parse/Parser.cpp
+++ b/clang/lib/Parse/Parser.cpp
@@ -2690,6 +2690,13 @@ bool Parser::ParseModuleName(
       return true;
     }
 
+    // P3034R1: Module Declarations Shouldn’t be Macros
+    if (!IsImport && Tok.getLocation().isMacroID()) {
+      Diag(Tok, diag::err_module_decl_cannot_be_macros);
+      SkipUntil(tok::semi);
+      return true;
+    }
+
     // Record this part of the module path.
     Path.push_back(std::make_pair(Tok.getIdentifierInfo(), Tok.getLocation()));
     ConsumeToken();
diff --git a/clang/test/CXX/cpp/cpp.module/p1.cppm b/clang/test/CXX/cpp/cpp.module/p1.cppm
new file mode 100644
index 00000000000000..b439366db3fba0
--- /dev/null
+++ b/clang/test/CXX/cpp/cpp.module/p1.cppm
@@ -0,0 +1,13 @@
+// RUN: %clang_cc1 -std=c++20 -emit-module-interface %s -triple x86_64-linux-gnu -DTEST=1 -verify
+// RUN: %clang_cc1 -std=c++20 -emit-module-interface %s -triple x86_64-linux-gnu -DTEST=2 -verify
+
+module;
+export module x;
+#include "version.h"
+#if TEST == 1
+export module VERSION;  // expected-error {{module declaration cannot be a macro}}
+#endif // TEST == 1
+
+#if TEST == 2
+export module A.B;      // expected-error {{module declaration cannot be a macro}}
+#endif // TEST == 2
diff --git a/clang/test/CXX/cpp/cpp.module/version.h b/clang/test/CXX/cpp/cpp.module/version.h
new file mode 100644
index 00000000000000..4608934290950b
--- /dev/null
+++ b/clang/test/CXX/cpp/cpp.module/version.h
@@ -0,0 +1,8 @@
+#ifndef VERSION_H
+#define VERSION_H
+
+#define VERSION libv5
+#define A a
+#define B b
+
+#endif
diff --git a/clang/test/CXX/module/basic/basic.link/module-declaration.cpp b/clang/test/CXX/module/basic/basic.link/module-declaration.cpp
index d71358cc7a571f..aa4bb52a57face 100644
--- a/clang/test/CXX/module/basic/basic.link/module-declaration.cpp
+++ b/clang/test/CXX/module/basic/basic.link/module-declaration.cpp
@@ -9,26 +9,26 @@
 //
 // Module implementation for unknown and known module. (The former is ill-formed.)
 // RUN: %clang_cc1 -std=c++20 -I%t -fmodule-file=x.y=%t/x.y.pcm -verify -x c++ %t/M.cpp \
-// RUN:            -DTEST=1 -DEXPORT= -DMODULE_NAME=z
+// RUN:            -DTEST=1
 // RUN: %clang_cc1 -std=c++20 -I%t -fmodule-file=x=%t/x.pcm -fmodule-file=x.y=%t/x.y.pcm -verify -x c++ %t/M.cpp \
-// RUN:            -DTEST=2 -DEXPORT= -DMODULE_NAME=x
+// RUN:            -DTEST=2
 //
 // Module interface for unknown and known module. (The latter is ill-formed due to
 // redefinition.)
 // RUN: %clang_cc1 -std=c++20 -I%t -fmodule-file=x.y=%t/x.y.pcm -verify %t/M.cpp \
-// RUN:            -DTEST=3 -DEXPORT=export -DMODULE_NAME=z
+// RUN:            -DTEST=3
 // RUN: %clang_cc1 -std=c++20 -I%t -fmodule-file=x.y=%t/x.y.pcm -verify %t/M.cpp \
-// RUN:            -DTEST=4 -DEXPORT=export -DMODULE_NAME=x
+// RUN:            -DTEST=4
 //
 // Miscellaneous syntax.
 // RUN: %clang_cc1 -std=c++20 -I%t -fmodule-file=x.y=%t/x.y.pcm -verify %t/M.cpp \
-// RUN:            -DTEST=7 -DEXPORT=export -DMODULE_NAME='z elderberry'
+// RUN:            -DTEST=7
 // RUN: %clang_cc1 -std=c++20 -I%t -fmodule-file=x.y=%t/x.y.pcm -verify %t/M.cpp \
-// RUN:            -DTEST=8 -DEXPORT=export -DMODULE_NAME='z [[]]'
+// RUN:            -DTEST=8
 // RUN: %clang_cc1 -std=c++20 -I%t -fmodule-file=x.y=%t/x.y.pcm -verify %t/M.cpp \
-// RUN:            -DTEST=9 -DEXPORT=export -DMODULE_NAME='z [[fancy]]'
+// RUN:            -DTEST=9
 // RUN: %clang_cc1 -std=c++20 -I%t -fmodule-file=x.y=%t/x.y.pcm -verify %t/M.cpp \
-// RUN:            -DTEST=10 -DEXPORT=export -DMODULE_NAME='z [[maybe_unused]]'
+// RUN:            -DTEST=10
 
 //--- x.cppm
 export module x;
@@ -40,15 +40,20 @@ int c;
 
 //--- M.cpp
 
-EXPORT module MODULE_NAME;
-#if TEST == 7
-// expected-error@-2 {{expected ';'}} expected-error@-2 {{a type specifier is required}}
+#if TEST == 1
+module z; // expected-error {{module 'z' not found}}
+#elif TEST == 2
+module x; // expected-no-diagnostics
+#elif TEST == 3
+export module z; // expected-no-diagnostics
+#elif TEST == 4
+export module x; // expected-no-diagnostics
+#elif TEST == 7
+export module z elderberry; // expected-error {{expected ';'}} expected-error {{a type specifier is required}}
 #elif TEST == 9
-// expected-warning@-4 {{unknown attribute 'fancy' ignored}}
+export module z [[fancy]]; // expected-warning {{unknown attribute 'fancy' ignored}}
 #elif TEST == 10
-// expected-error-re@-6 {{'maybe_unused' attribute cannot be applied to a module{{$}}}}
-#elif TEST == 1
-// expected-error@-8 {{module 'z' not found}}
+export module z [[maybe_unused]]; // expected-error-re {{'maybe_unused' attribute cannot be applied to a module{{$}}}}
 #else
 // expected-no-diagnostics
 #endif
diff --git a/clang/test/CXX/module/dcl.dcl/dcl.module/dcl.module.import/p1.cppm b/clang/test/CXX/module/dcl.dcl/dcl.module/dcl.module.import/p1.cppm
index 873e4c0edeac25..074589ccc26926 100644
--- a/clang/test/CXX/module/dcl.dcl/dcl.module/dcl.module.import/p1.cppm
+++ b/clang/test/CXX/module/dcl.dcl/dcl.module/dcl.module.import/p1.cppm
@@ -35,9 +35,9 @@ int use_3 = c; // expected-error {{use of undeclared identifier 'c'}}
 
 //--- test.cpp
 #ifdef INTERFACE
-export module MODULE_NAME;
+export module MODULE_NAME; // expected-error {{module declaration cannot be a macro}}
 #else
-module MODULE_NAME;
+module MODULE_NAME; // expected-error {{module declaration cannot be a macro}}
 #endif
 
 import x;
diff --git a/clang/test/SemaCXX/modules.cppm b/clang/test/SemaCXX/modules.cppm
index 41204be76eafa1..75bbc5366d4a71 100644
--- a/clang/test/SemaCXX/modules.cppm
+++ b/clang/test/SemaCXX/modules.cppm
@@ -7,6 +7,10 @@
 // expected-no-diagnostics
 #endif
 
+#if TEST == 3
+// expected-error {{module declaration cannot be a macro}}
+#endif //  TEST == 3
+
 export module foo;
 
 static int m;
diff --git a/clang/www/cxx_status.html b/clang/www/cxx_status.html
index 0996abc2405857..8ae9a25caf3604 100755
--- a/clang/www/cxx_status.html
+++ b/clang/www/cxx_status.html
@@ -182,7 +182,7 @@ <h2 id="cxx26">C++2c implementation status</h2>
  <tr>
   <td>Module Declarations Shouldn’t be Macros</td>
   <td><a href="https://wg21.link/P3034R1">P3034R1</a> (<a href="#dr">DR</a>)</td>
-  <td class="none" align="center">No</td>
+  <td class="unreleased" align="center">Clang 19</td>
  </tr>
  <tr>
   <td>Trivial infinite loops are not Undefined Behavior</td>

clang/lib/Parse/Parser.cpp

clang/include/clang/Basic/DiagnosticParseKinds.td

clang/test/CXX/cpp/cpp.module/p1.cppm

ChuanqiXu9

LGTM otherwise. I'd like to leave this to @cor3ntin

clang/test/CXX/cpp/cpp.module/p1.cppm

yronglin · 2024-04-30T15:36:23Z

The paper does not clearly says whether disallow function-like macro is also needed, but I think disallow function-like macro has the same goal as the paper. WDYT? @cor3ntin @ChuanqiXu9

The wording in the paper said:
No identifier in the pp-module-name or pp-module-partition shall currently be defined as an object-like macro.

cor3ntin · 2024-04-30T15:45:15Z

A function like macro needs parentheses to be substituted. As such,

#define foo()
module foo;

Should be allowed (and foo is not a macro expansion on line 2)

module foo(); should be Ill-formed.

ChuanqiXu9 · 2024-04-30T15:46:08Z

The paper does not clearly says whether disallow function-like macro is also needed, but I think disallow function-like macro has the same goal as the paper. WDYT? @cor3ntin @ChuanqiXu9

The wording in the paper said: No identifier in the pp-module-name or pp-module-partition shall currently be defined as an object-like macro.

The intention of the paper is, we can get the module name of a TU by cat and grep. So I feel the current wording is correct: https://godbolt.org/z/45xnsh7Eh

yronglin · 2024-04-30T16:16:33Z

module foo(); should be Ill-formed.

Ahh, so case like the following also should be ill-formed:

#define FUNC_LIKE(X) function_like_##X
export module FUNC_LIKE(bar);

we can get the module name of a TU by cat and grep

This means that no macros of any kind can appear in the module name.

Thank you all. Things much clearer now.

cor3ntin · 2024-04-30T16:33:08Z

This means that no macros of any kind can appear in the module name.

Exactly. This is why the grammar in the wording is defined in terms of pp-token and not identifiers: no macro expansion takes place at all.

yronglin · 2024-04-30T16:45:26Z

This means that no macros of any kind can appear in the module name.

Exactly. This is why the grammar in the wording is defined in terms of pp-token and not identifiers: no macro expansion takes place at all.

Thanks! Let's use LexUnexpandedToken during parsing module name.

Signed-off-by: yronglin <yronglin777@gmail.com>

github-actions · 2024-05-03T12:09:57Z

✅ With the latest revision this PR passed the C/C++ code formatter.

clang/lib/Parse/Parser.cpp

Signed-off-by: yronglin <yronglin777@gmail.com>

yronglin · 2024-05-03T13:59:59Z

Dose this note have a conflict with P3034R1?

[Note 1: Each identifier currently defined as a macro name is replaced by its replacement list of preprocessing tokens. — end note]

cor3ntin · 2024-05-03T14:05:42Z

Dose this note have a conflict with P3034R1?

[Note 1: Each identifier currently defined as a macro name is replaced by its replacement list of preprocessing tokens. — end note]

My reading is that

#define SOME_MACRO
module foo SOME_MACRO;

SOME_MACRO is expanded

cor3ntin

I think the approach looks good.

Do we have existing tests for the use of module as an identifier outside of a module declaration?

clang/test/CXX/cpp/cpp.module/p2.cppm

yronglin · 2024-05-03T14:26:49Z

I think the approach looks good.

Do we have existing tests for the use of module as an identifier outside of a module declaration?

IIUC, do you mean something looks like the following? I didn't find it in the test case:

void foo() {
  int module = 0;
}

Signed-off-by: yronglin <yronglin777@gmail.com>

yronglin · 2024-05-03T14:58:02Z

My reading is that
#define SOME_MACRO
module foo SOME_MACRO;
SOME_MACRO is expanded

If this is the case, the current processing in the Preprocessor::LexAfterModuleDecl function is incorrect. The implementation in this PR treats the tokens between module and ; as normal text(use LexUnexpandedToken). So I'm a bit confused about the wording of [cpp.module]/p3 and the note.

Any preprocessing tokens after the module preprocessing token in the module directive are processed just as in normal text.
[Note 1: Each identifier currently defined as a macro name is replaced by its replacement list of preprocessing tokens. — end note]

cor3ntin · 2024-05-04T14:52:35Z

I think the approach looks good.
Do we have existing tests for the use of module as an identifier outside of a module declaration?

IIUC, do you mean something looks like the following? I didn't find it in the test case:
void foo() {
  int module = 0;
}

Yes, it might be useful to have that somewhere

I think in ParseModuleDecl, you want to reset the lexer kind before parsing attributes.
(and add tests for that)

Here is a test:

#define ATTRS [[]]
#define SEMICOLON
export module unexpanded : unexpanded : ATTRS SEMICOLON

Sorry i did not notice that earlier.
The goal of the paper is that the name of the module is not a macro. everything else can be, including attributes attached to the module

yronglin · 2024-05-04T15:48:02Z

Thanks! I'd like to move the implementation from Parser to Preprocessor. I think It would make more sense to do these checks during lexing.

cor3ntin

LGTM. I think all the concerns have been addressed.

Give it until tomorrow before landing in case @ChuanqiXu9 @Bigcheese @AaronBallman have additional comments

Thanks a lot

yronglin · 2024-07-18T17:31:11Z

Thank you, I can't finish this PR without your help.

ChuanqiXu9

No more comments from me.

yronglin · 2024-07-20T12:42:21Z

I landed this PR and I'd be happy to follow up if you have any concerns.

dcci · 2024-07-22T03:31:30Z

This commit seems to have broken well-formed code in thrift:

fbcode/thrift/compiler/generate/t_py_generator.cc:881:20: error: declaration of variable 'module' with deduced type 'const auto &' requires an initializer
  881 |   for (const auto &module : modules) {
      |                    ^
fbcode/thrift/compiler/generate/t_py_generator.cc:881:27: error: expected ';' in 'for' statement specifier
  881 |   for (const auto &module : modules) {
      |                           ^
fbcode/thrift/compiler/generate/t_py_generator.cc:881:27: error: expected expression
fbcode/thrift/compiler/generate/t_py_generator.cc:881:27: error: expected ';' in 'for' statement specifier
4 errors generated.

dcci · 2024-07-22T03:32:50Z

Code in question:
https://github.com/facebook/fbthrift/blob/ccfcd6743488c26d720bc4ff3348534491078b43/thrift/compiler/generate/t_py_generator.cc#L881

^ I am trying to find out a reduced testcase, but sending this here in case it rings a bell.

mizvekov · 2024-07-22T03:57:08Z

I am also seeing breakages which are solved by reverting this change.

The failure occurs when importing modules from within header files:

error: expected a module name after 'import'
   11 | import std;

yronglin · 2024-07-22T04:00:54Z

Thank you for reporting this issue. if we have a reproducer, I'll try to quick fix it today.

mizvekov · 2024-07-22T04:13:15Z

I don't think I'll be able to provide a reproducer today. Regardless, bugs in modules are in general not easy to reduce.
Unless you think you can fix this soon enough, I think a revert is appropriate here.

…cros" (#99838) Reverts #90574

yronglin · 2024-07-22T05:22:20Z

I am also seeing breakages which are solved by reverting this change.

The failure occurs when importing modules from within header files:
error: expected a module name after 'import'
   11 | import std;

It would be nice to have a reproducer. I can't tell the root cause from this error, so I can't use it to strengthen the current tests.

import std is definitely covered by the current test, but we can get more useful information if you provide some more context.

yronglin · 2024-07-22T05:24:01Z

This commit seems to have broken well-formed code in thrift:

fbcode/thrift/compiler/generate/t_py_generator.cc:881:20: error: declaration of variable 'module' with deduced type 'const auto &' requires an initializer
  881 |   for (const auto &module : modules) {
      |                    ^
fbcode/thrift/compiler/generate/t_py_generator.cc:881:27: error: expected ';' in 'for' statement specifier
  881 |   for (const auto &module : modules) {
      |                           ^
fbcode/thrift/compiler/generate/t_py_generator.cc:881:27: error: expected expression
fbcode/thrift/compiler/generate/t_py_generator.cc:881:27: error: expected ';' in 'for' statement specifier
4 errors generated.

This is clearer, I think I may have figured out where the problem is.

mizvekov · 2024-07-22T05:33:13Z

It would be nice to have a reproducer. I can't tell the root cause from this error, so I can't use it to strengthen the current tests.

I intend to provide a reproducer. I just can't do it today. So don't wait on it as a justification to avoid reverting.

dcci · 2024-07-22T05:34:43Z

This is clearer, I think I may have figured out where the problem is.

^ I have a reproducer that's running through creduce. It should be ready tomorrow morning PST time, and I'll add you here. In the meanwhile, do you mind if I revert this given we understand it breaks several cases so we can get our services building again? It affected many codebases.

dcci · 2024-07-22T05:36:49Z

Notice you already reverted, thanks. I'll follow-up with a reproducer once creduce finishes running.

yronglin · 2024-07-22T05:41:10Z

Thanks!

yronglin · 2024-07-22T11:09:44Z

It would be nice to have a reproducer. I can't tell the root cause from this error, so I can't use it to strengthen the current tests.

I intend to provide a reproducer. I just can't do it today. So don't wait on it as a justification to avoid reverting.

The PR has already been reverted before this, and no one is avoiding reverting it.

cor3ntin · 2024-07-22T11:55:28Z

When you create a new PR, can you try to preserve the history of your commits, so that we can easily see what you changed? Thanks

yronglin · 2024-07-22T12:32:47Z

When you create a new PR, can you try to preserve the history of your commits, so that we can easily see what you changed? Thanks

Sure, I'd be happy to do that! I will put the new changes in a separate commit. 😁

dcci · 2024-07-22T16:43:22Z

Reduced: #99894

yronglin · 2024-07-24T15:28:39Z

After investigation, it was found that the root cause of the problem was that this PR mistakenly treated some identifiers named module as module-keywords, and packaged the subsequent identifiers into annot_module_name.

…0574) Summary: This PR implement [P3034R1 Module Declarations Shouldn’t be Macros](https://wg21.link/P3034R1), and refactor the convoluted state machines in module name lexical analysis. --------- Signed-off-by: yronglin <yronglin777@gmail.com> Co-authored-by: Aaron Ballman <aaron@aaronballman.com> Co-authored-by: cor3ntin <corentinjabot@gmail.com> Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251236

…cros" (#99838) Summary: Reverts #90574 Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D60251154

[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros

1dcb4c3

Signed-off-by: yronglin <yronglin777@gmail.com>

yronglin requested review from ChuanqiXu9 and cor3ntin April 30, 2024 09:20

llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" clang:modules C++20 modules and Clang Header Modules labels Apr 30, 2024

cor3ntin reviewed Apr 30, 2024

View reviewed changes

clang/lib/Parse/Parser.cpp Outdated Show resolved Hide resolved

clang/include/clang/Basic/DiagnosticParseKinds.td Outdated Show resolved Hide resolved

clang/test/CXX/cpp/cpp.module/p1.cppm Outdated Show resolved Hide resolved

ChuanqiXu9 reviewed Apr 30, 2024

View reviewed changes

clang/test/CXX/cpp/cpp.module/p1.cppm Outdated Show resolved Hide resolved

yronglin added 2 commits May 3, 2024 20:06

Use split-file in test and improve implementation

0b472f2

Signed-off-by: yronglin <yronglin777@gmail.com>

Format

fd75d83

Signed-off-by: yronglin <yronglin777@gmail.com>

cor3ntin reviewed May 3, 2024

View reviewed changes

clang/lib/Parse/Parser.cpp Outdated Show resolved Hide resolved

yronglin added 2 commits May 3, 2024 21:47

Do not treat no '(' following function-like macro as a macro name

265189b

Signed-off-by: yronglin <yronglin777@gmail.com>

Merge branch 'main' into P3034R1

1f44657

cor3ntin reviewed May 3, 2024

View reviewed changes

clang/test/CXX/cpp/cpp.module/p2.cppm Outdated Show resolved Hide resolved

cor3ntin requested a review from Bigcheese May 3, 2024 14:10

Add new line at the end of file

611e1d8

Signed-off-by: yronglin <yronglin777@gmail.com>

cor3ntin approved these changes Jul 18, 2024

View reviewed changes

ChuanqiXu9 reviewed Jul 19, 2024

View reviewed changes

yronglin merged commit e77a01d into llvm:main Jul 20, 2024

yronglin mentioned this pull request Jul 22, 2024

Revert "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros" #99838

Merged

yronglin added a commit that referenced this pull request Jul 22, 2024

Revert "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Ma…

c91e852

…cros" (#99838) Reverts #90574

yronglin mentioned this pull request Aug 6, 2024

Reapply "[Clang] Implement P3034R1 Module Declarations Shouldn’t be Macros" #102135

Closed

yronglin mentioned this pull request Jun 3, 2025

[C++20][Modules] Implement P1857R3 Modules Dependency Discovery #107168

Merged

pinskia mentioned this pull request Jul 1, 2025

C++: accepts invalid export module #146469

Open

Conversation

yronglin commented Apr 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

llvmbot commented Apr 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ChuanqiXu9 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yronglin commented Apr 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cor3ntin commented Apr 30, 2024

Uh oh!

ChuanqiXu9 commented Apr 30, 2024

Uh oh!

yronglin commented Apr 30, 2024

Uh oh!

cor3ntin commented Apr 30, 2024

Uh oh!

yronglin commented Apr 30, 2024

Uh oh!

github-actions bot commented May 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

yronglin commented May 3, 2024

Uh oh!

cor3ntin commented May 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cor3ntin left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

yronglin commented May 3, 2024

Uh oh!

yronglin commented May 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cor3ntin commented May 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yronglin commented May 4, 2024

Uh oh!

cor3ntin left a comment

Choose a reason for hiding this comment

Uh oh!

yronglin commented Jul 18, 2024

Uh oh!

ChuanqiXu9 left a comment

Choose a reason for hiding this comment

Uh oh!

yronglin commented Jul 20, 2024

Uh oh!

dcci commented Jul 22, 2024

Uh oh!

dcci commented Jul 22, 2024

Uh oh!

mizvekov commented Jul 22, 2024

Uh oh!

yronglin commented Jul 22, 2024

Uh oh!

mizvekov commented Jul 22, 2024

Uh oh!

yronglin commented Jul 22, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

yronglin commented Jul 22, 2024

Uh oh!

mizvekov commented Jul 22, 2024

Uh oh!

dcci commented Jul 22, 2024

Uh oh!

dcci commented Jul 22, 2024

yronglin commented Apr 30, 2024 •

edited

Loading

llvmbot commented Apr 30, 2024 •

edited

Loading

yronglin commented Apr 30, 2024 •

edited

Loading

github-actions bot commented May 3, 2024 •

edited

Loading

cor3ntin commented May 3, 2024 •

edited

Loading

yronglin commented May 3, 2024 •

edited

Loading

cor3ntin commented May 4, 2024 •

edited

Loading

yronglin commented Jul 22, 2024 •

edited

Loading