[Test][ORC][JITLink] Preserve rbx in the test ExecutionEngine/JITLink/x86-64/ELF_vtune.s
#86472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ With the latest revision this PR passed the Python code formatter. |
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
|
Hi, do you mean preserve |
yingcong-wu
changed the title
ExecutionEngine/JITLink/x86-64/ELF_vtune.sExecutionEngine/JITLink/x86-64/ELF_vtune.s
Updated, thanks. |
I believe we do not need to update cfi directives here since we didn't modify anything related to the frame pointer. But please correct me if anyone believes I made a mistake here. |
hongyu-dev
reviewed
Apr 7, 2024
|
Very belatedly -- LGTM. Thanks @yingcong-wu! |
lhames
approved these changes
Apr 15, 2024
|
No problem. Thank you @lhames and @yugier . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callee should preserve rbx according to the calling convention, but it is not in the test case
ExecutionEngine/JITLink/x86-64/ELF_vtune.s. Not preserving the rbx register may result in some random error to the caller function. This patch adds the missing command to preserve the rbx.