Skip to content

[llvm][ARM][AArch64] Add conflicting module flag check to the verifier. #83635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DanielKristofKiss wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[llvm][ARM][AArch64] Add conflicting module flag check to the verifier. #83635

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions llvm/lib/IR/Verifier.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1744,6 +1744,22 @@ void Verifier::visitModuleFlags() {
continue;
}
}

// Validate only one of the flags set with none zero value.
auto isModuleAttributeSet = [&](const StringRef &ModAttr) -> bool {
const auto *Attr =
mdconst::extract_or_null<ConstantInt>(M.getModuleFlag(ModAttr));
return Attr && Attr->getZExtValue();
};
const std::pair<StringRef, StringRef> ConflictingFlags[] = {
{"sign-return-address", "sign-return-address-all"}};

for (auto FlagPair : ConflictingFlags) {
if (isModuleAttributeSet(FlagPair.first) &&
isModuleAttributeSet(FlagPair.second))
CheckFailed("invalid pair of flags set as " + FlagPair.first + " and " +
FlagPair.second);
}
}

void
Expand Down
6 changes: 5 additions & 1 deletion llvm/test/Verifier/module-flags-1.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,10 @@
!14 = !{i32 1, !"flag-1", i32 55}
!15 = !{i32 3, !"bar", !{!"flag-1", i32 55}}

!22 = !{i32 8, !"sign-return-address", i32 1}
!23 = !{i32 8, !"sign-return-address-all", i32 1}
; CHECK-NOT: invalid set of flags set as sign-return-address and sign-return-address-all

!llvm.module.flags = !{
!0, !1, !2, !3, !4, !5, !6, !7, !8, !9, !10, !11, !12, !13, !14, !15,
!16, !17, !18, !19, !20, !21 }
!16, !17, !18, !19, !20, !21, !22, !23 }