Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[OpenMP][AIX]Add assembly file containing microtasking routines and unnamed common block definitions #81770

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

xingxue-ibm
Copy link
Contributor

This patch adds assembly file z_AIX_asm.S that contains the 32- and 64-bit XCOFF version of microtasking routines and unnamed common block definitions. This code has been run through the libomp LIT tests and a user package successfully.

…mmon block definitionis for 32-bit and 64-bit modes.
@xingxue-ibm xingxue-ibm added the openmp:libomp OpenMP host runtime label Feb 14, 2024
@xingxue-ibm xingxue-ibm self-assigned this Feb 14, 2024
@brad0
Copy link
Contributor

brad0 commented Feb 18, 2024

@shiltian

@xingxue-ibm
Copy link
Contributor Author

Gentle ping.

Copy link
Contributor

@shiltian shiltian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late response. I'm not familiar with AIX asm so I assume this has been thoroughly tested.

@xingxue-ibm
Copy link
Contributor Author

Sorry for the late response. I'm not familiar with AIX asm so I assume this has been thoroughly tested.

Thanks @shiltian and @brad0! Yeah, the code went through libomp LIT tests and internal review.

@xingxue-ibm xingxue-ibm merged commit 94100bc into llvm:main Feb 20, 2024
6 checks passed
llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Feb 20, 2024
…nnamed common block definitions (llvm#81770)

This patch adds assembly file `z_AIX_asm.S` that contains the 32- and
64-bit XCOFF version of microtasking routines and unnamed common block
definitions. This code has been run through the libomp LIT tests and a
user package successfully.

(cherry picked from commit 94100bc)
llvmbot pushed a commit to llvmbot/llvm-project that referenced this pull request Feb 20, 2024
…nnamed common block definitions (llvm#81770)

This patch adds assembly file `z_AIX_asm.S` that contains the 32- and
64-bit XCOFF version of microtasking routines and unnamed common block
definitions. This code has been run through the libomp LIT tests and a
user package successfully.

(cherry picked from commit 94100bc)
@pointhex pointhex mentioned this pull request May 7, 2024
@xingxue-ibm xingxue-ibm deleted the z_AIX_asm branch May 24, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
openmp:libomp OpenMP host runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants