Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace exec_tools with tools in bazel genrule. #77510

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

denglesberg-splunk
Copy link
Contributor

As of the Bazel 6.x series, there is no difference between the exec_tools and tools. Bazel 7 removes the exec_tools attribute entirely. This commit updates to use the cannonical attribute name to allow building `clang-tidy``with bazel 7.0.0, though it does not change the default bazel version which remains at 6.1.2.

See also bazelbuild/bazel#19132 for more information.

As of the Bazel 6.x series, there is no difference between the `exec_tools` and
`tools`. Bazel 7 removes the `exec_tools` attribute entirely. This commit
updates to use the cannonical attribute name to allow building
`clang-tidy``with bazel 7.0.0, though it does not change the default bazel
version which remains at 6.1.2.

See also bazelbuild/bazel#19132 for more information.
Copy link

github-actions bot commented Jan 9, 2024

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be
notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write
permissions for the repository. In which case you can instead tag reviewers by
name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review
by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate
is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@denglesberg-splunk
Copy link
Contributor Author

denglesberg-splunk commented Jan 9, 2024

@njames93 Could you please take a look?

Or if a different code owner is appropriate because this is not directly clang-tidy could you help me to find them? Thanks!

@denglesberg-splunk
Copy link
Contributor Author

@akuegel are you a suitable reviewer here? Thanks!

@akuegel akuegel merged commit 3b54337 into llvm:main Jan 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants