Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clang report invalid target versions. #75373

Merged
merged 36 commits into from
Jan 9, 2024
Merged
Changes from 1 commit
Commits
Show all changes
36 commits
Select commit Hold shift + click to select a range
74f256d
Make clang report garbage target versions.
ZijunZhaoCCK Dec 13, 2023
0d159b2
rephrase
ZijunZhaoCCK Dec 13, 2023
835a605
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Dec 14, 2023
b2dda9c
Make clang report garbage target versions.
ZijunZhaoCCK Dec 13, 2023
8317657
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Dec 14, 2023
8519713
Make clang report garbage target versions.
ZijunZhaoCCK Dec 13, 2023
48004fe
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Dec 14, 2023
a726fe2
Make clang report garbage target versions.
ZijunZhaoCCK Dec 13, 2023
bef0de6
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Dec 14, 2023
8ed23ef
Make clang report garbage target versions.
ZijunZhaoCCK Dec 13, 2023
9f5c7b3
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Dec 14, 2023
1827977
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Dec 15, 2023
6e62da1
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Dec 15, 2023
01128aa
Make clang report garbage target versions.
ZijunZhaoCCK Dec 13, 2023
a6d5ffa
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Dec 20, 2023
1fdd390
Make clang report garbage target versions.
ZijunZhaoCCK Dec 13, 2023
2c0435b
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Dec 20, 2023
752df27
Make clang report invalid target versions.
ZijunZhaoCCK Dec 13, 2023
1136d39
Make clang report invalid target versions.
ZijunZhaoCCK Dec 13, 2023
c2e346f
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Jan 2, 2024
9d1abab
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Jan 2, 2024
e889780
reformat
ZijunZhaoCCK Jan 2, 2024
01f4d21
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Jan 2, 2024
e0af303
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Jan 2, 2024
7493294
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Jan 4, 2024
bc0ea97
1. update tests 2. update getEnvironmentVersion()
ZijunZhaoCCK Jan 4, 2024
917c7ea
add newline
ZijunZhaoCCK Jan 4, 2024
d7ffb28
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Jan 4, 2024
d015606
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Jan 4, 2024
fb1673e
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Jan 5, 2024
951e753
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Jan 8, 2024
ff42931
update tests
ZijunZhaoCCK Jan 8, 2024
2bf1fcd
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Jan 9, 2024
f1efb18
update tests
ZijunZhaoCCK Jan 8, 2024
c98888d
Merge branch 'llvm:main' into clang-warning
ZijunZhaoCCK Jan 9, 2024
5d89e7f
update error msg and tests
ZijunZhaoCCK Jan 8, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion llvm/lib/TargetParser/Triple.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
#include "llvm/ADT/StringExtras.h"
#include "llvm/ADT/StringSwitch.h"
#include "llvm/Support/ErrorHandling.h"
#include "llvm/Support/raw_ostream.h"
#include "llvm/Support/SwapByteOrder.h"
#include "llvm/Support/VersionTuple.h"
#include "llvm/TargetParser/ARMTargetParser.h"
Expand Down Expand Up @@ -1199,7 +1200,11 @@ StringRef Triple::getOSAndEnvironmentName() const {

static VersionTuple parseVersionFromName(StringRef Name) {
VersionTuple Version;
Version.tryParse(Name);
if (Version.tryParse(Name)) {
errs() << "The input is "<< Name << " and it is invalid. Should pass an "<<
"integer or integer combination! e.g. 2, 9.5 or 3.4.5\n";
ZijunZhaoCCK marked this conversation as resolved.
Show resolved Hide resolved
exit(1);
}
return Version.withoutBuild();
}

Expand Down
Loading