Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flang][openacc] Warn about misplaced end loop directive and ignore it #69512

Merged
merged 1 commit into from
Oct 19, 2023
Merged

[flang][openacc] Warn about misplaced end loop directive and ignore it #69512

merged 1 commit into from
Oct 19, 2023

Conversation

clementval
Copy link
Contributor

Instead of raising an error for a misplaced end loop directive, just warn about it and ignore it. This directive is an extension and is optional.

@llvmbot llvmbot added flang Flang issues not falling into any other category flang:fir-hlfir openacc flang:semantics flang:parser labels Oct 18, 2023
razvanlupusoru
razvanlupusoru approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@razvanlupusoru razvanlupusoru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed - this is reasonable.

@clementval clementval merged commit d2e7a15 into llvm:main Oct 19, 2023
3 checks passed
@clementval clementval deleted the acc_parser_error branch October 19, 2023 15:49
@madhur13490 madhur13490 mentioned this pull request Oct 20, 2023
Closed
@banach-space banach-space mentioned this pull request Oct 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@razvanlupusoru razvanlupusoru razvanlupusoru approved these changes

@vzakhari vzakhari Awaiting requested review from vzakhari

Assignees
No one assigned
Labels
flang:fir-hlfir flang:parser flang:semantics flang Flang issues not falling into any other category openacc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clementval @razvanlupusoru @llvmbot