[mlir] ADTExtras: include mlir/Support/LLVM.h #69479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To forward-declare LLVM's support types.
|
@llvm/pr-subscribers-mlir @llvm/pr-subscribers-mlir-core Author: Emilio Cota (cota) ChangesTo forward-declare LLVM's support types. Full diff: https://github.com/llvm/llvm-project/pull/69479.diff 1 Files Affected:
diff --git a/mlir/include/mlir/Support/ADTExtras.h b/mlir/include/mlir/Support/ADTExtras.h
index 1e4708f8f7d3f9e..51ec7ac25dbb599 100644
--- a/mlir/include/mlir/Support/ADTExtras.h
+++ b/mlir/include/mlir/Support/ADTExtras.h
@@ -9,6 +9,7 @@
#ifndef MLIR_SUPPORT_ADTEXTRAS_H
#define MLIR_SUPPORT_ADTEXTRAS_H
+#include "mlir/Support/LLVM.h"
#include "llvm/ADT/ArrayRef.h"
#include "llvm/ADT/SmallVector.h"
|
|
Is this required? I assumed the complete definitions of |
|
It is required for Bazel builds, which requires self-contained header files. An alternative would be to prepend |
|
Ah, in that case this LGTM |
MacDue
approved these changes
Oct 18, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To forward-declare LLVM's support types.