Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AMDGPU] Use correct operand order for shifts #68299

Merged
merged 1 commit into from
Oct 6, 2023

Commits on Oct 5, 2023

  1. [AMDGPU] Use correct operand order for shifts

    In a special case in frame index elimination (when the offset is 0), we
    generate either a S_LSHR_B32 or a V_LSHRREV_B32 using the same code.
    However, they don't expect their operands in the same order - S_LSHR_B32
    takes the value to be shifted first and then the shift amount, whereas
    V_LSHRREV_B32 has the operands reversed (hence the REV in its name).
    Update the code & tests to take this into account. Also remove an
    outdated comment (this code is definitely reachable now that non-entry
    functions no longer have a fixed emergency scavenge slot).
    rovka committed Oct 5, 2023
    Configuration menu
    Copy the full SHA
    da55159 View commit details
    Browse the repository at this point in the history