Skip to content

[Clang] [Tests] Add more tests for #210802 - #217735

Merged
Sirraide merged 1 commit into
llvm:mainfrom
Sirraide:add-tests-for-210802
Aug 21, 2026
Merged

Sirraide merged 1 commit into
llvm:mainfrom
Sirraide:add-tests-for-210802

Conversation

@Sirraide

Copy link
Copy Markdown
Member

Shafik requested more tests for #210802.

@Sirraide
Sirraide requested a review from shafik August 20, 2026 18:56
@Sirraide Sirraide added the clang:frontend Language frontend issues, e.g. anything involving "Sema" label Aug 20, 2026
@llvmorg-github-actions llvmorg-github-actions Bot added the clang Clang issues not falling into any other category label Aug 20, 2026
@llvmorg-github-actions

Copy link
Copy Markdown

@llvm/pr-subscribers-clang

Author: Ambrose Leeb (Sirraide)

Changes

Shafik requested more tests for #210802.


Full diff: https://github.com/llvm/llvm-project/pull/217735.diff

1 Files Affected:

  • (modified) clang/test/Preprocessor/pragma_set_pp_state.cpp (+15)
diff --git a/clang/test/Preprocessor/pragma_set_pp_state.cpp b/clang/test/Preprocessor/pragma_set_pp_state.cpp
index 763f23ce5868f..5e3f9179604a7 100644
--- a/clang/test/Preprocessor/pragma_set_pp_state.cpp
+++ b/clang/test/Preprocessor/pragma_set_pp_state.cpp
@@ -9,9 +9,24 @@
 #pragma clang __set_pp_state __GLIBCXX__ foo // expected-error {{expected integer after '#pragma clang __set_pp_state __GLIBCXX__'}}
 #pragma clang __set_pp_state __GLIBCXX__ 100000000000000000000000000000 // expected-error {{expected integer after '#pragma clang __set_pp_state __GLIBCXX__'}}
 #pragma clang __set_pp_state __GLIBCXX__ 42.0 // expected-error {{expected integer after '#pragma clang __set_pp_state __GLIBCXX__'}}
+#pragma clang __set_pp_state __GLIBCXX__ 42.0f // expected-error {{expected integer after '#pragma clang __set_pp_state __GLIBCXX__'}}
+#pragma clang __set_pp_state __GLIBCXX__ true // expected-error {{expected integer after '#pragma clang __set_pp_state __GLIBCXX__'}}
+#pragma clang __set_pp_state __GLIBCXX__ false // expected-error {{expected integer after '#pragma clang __set_pp_state __GLIBCXX__'}}
+#pragma clang __set_pp_state __GLIBCXX__ nullptr // expected-error {{expected integer after '#pragma clang __set_pp_state __GLIBCXX__'}}
+#pragma clang __set_pp_state __GLIBCXX__ 'a' // expected-error {{expected integer after '#pragma clang __set_pp_state __GLIBCXX__'}}
+#pragma clang __set_pp_state __GLIBCXX__ "asdfasdf" // expected-error {{expected integer after '#pragma clang __set_pp_state __GLIBCXX__'}}
+#pragma clang __set_pp_state __GLIBCXX__ u'a' // expected-error {{expected integer after '#pragma clang __set_pp_state __GLIBCXX__'}}
+#pragma clang __set_pp_state __GLIBCXX__ u"asdfasdf" // expected-error {{expected integer after '#pragma clang __set_pp_state __GLIBCXX__'}}
+#pragma clang __set_pp_state __GLIBCXX__ 1234_asdf // expected-error {{expected integer after '#pragma clang __set_pp_state __GLIBCXX__'}}
 
 #pragma clang __set_pp_state __GLIBCXX__ 42L
 #pragma clang __set_pp_state __GLIBCXX__ 42
+#pragma clang __set_pp_state __GLIBCXX__ 0x42
+#pragma clang __set_pp_state __GLIBCXX__ 042
+#pragma clang __set_pp_state __GLIBCXX__ 0b10100
+
+#define TWENTY 20
+#pragma clang __set_pp_state __GLIBCXX__ TWENTY
 
 // Check that we treat the identifier after '__set_pp_state' literally.
 #define MACRO __GLIBCXX__

@Fznamznon Fznamznon left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not Shafik, but LGTM just in case

@Sirraide
Sirraide merged commit 3c97cc0 into llvm:main Aug 21, 2026
15 checks passed
@Sirraide
Sirraide deleted the add-tests-for-210802 branch August 21, 2026 21:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

clang:frontend Language frontend issues, e.g. anything involving "Sema" clang Clang issues not falling into any other category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants