[Clang] Fixed auto parsing regression with brace initialization - #210347
Merged
Conversation
llvmorg-github-actions
Bot
added
clang
|
@llvm/pr-subscribers-clang Author: Tony Guillot (to268) ChangesThe PR #208552 has introduced a regression where brace initialization was not taken into account Full diff: https://github.com/llvm/llvm-project/pull/210347.diff 2 Files Affected:
diff --git a/clang/lib/Parse/ParseDecl.cpp b/clang/lib/Parse/ParseDecl.cpp
index 88f07bb104fcb..0825678acaf60 100644
--- a/clang/lib/Parse/ParseDecl.cpp
+++ b/clang/lib/Parse/ParseDecl.cpp
@@ -3879,10 +3879,10 @@ void Parser::ParseDeclarationSpecifiers(
// when a variable name matches a type brought in by a using-directive.
if (DS.getTypeSpecType() == DeclSpec::TST_auto) {
Token Next = NextToken();
- if (Next.isOneOf(tok::equal, tok::l_paren, tok::l_square, tok::amp,
- tok::ampamp, tok::star, tok::coloncolon, tok::comma,
- tok::semi, tok::colon, tok::greater, tok::r_paren,
- tok::arrow))
+ if (Next.isOneOf(tok::equal, tok::l_paren, tok::l_square, tok::l_brace,
+ tok::amp, tok::ampamp, tok::star, tok::coloncolon,
+ tok::comma, tok::semi, tok::colon, tok::greater,
+ tok::r_paren, tok::arrow))
goto DoneWithDeclSpec;
}
diff --git a/clang/test/CXX/dcl/dcl.spec/dcl.type/dcl.type.general/p2.cpp b/clang/test/CXX/dcl/dcl.spec/dcl.type/dcl.type.general/p2.cpp
new file mode 100644
index 0000000000000..5b0079a1ba898
--- /dev/null
+++ b/clang/test/CXX/dcl/dcl.spec/dcl.type/dcl.type.general/p2.cpp
@@ -0,0 +1,13 @@
+// RUN: %clang_cc1 -std=c++2c -verify %s
+
+namespace bug {
+void func1() {
+ typedef float foo; // expected-note {{previous definition is here}}
+ auto foo{16}; // expected-error {{redefinition of 'foo' as different kind of symbol}}
+}
+
+typedef float bar;
+void func2() {
+ auto bar{16};
+}
+} // namespace bug
|
cor3ntin
approved these changes
Jul 17, 2026
🐧 Linux x64 Test Results
Failed Tests(click on a test name to see its output) Profile-x86_64Profile-x86_64.Linux/counter_promo_for.c (Likely Already Failing)This test is already failing at the base commit.Profile-x86_64.Linux/counter_promo_while.c (Likely Already Failing)This test is already failing at the base commit.If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the |
1 similar comment
🐧 Linux x64 Test Results
Failed Tests(click on a test name to see its output) Profile-x86_64Profile-x86_64.Linux/counter_promo_for.c (Likely Already Failing)This test is already failing at the base commit.Profile-x86_64.Linux/counter_promo_while.c (Likely Already Failing)This test is already failing at the base commit.If these failures are unrelated to your changes (for example tests are broken or flaky at HEAD), please open an issue at https://github.com/llvm/llvm-project/issues and add the |
to268
force-pushed
the
fix-cxx-auto-lbrace
branch
2 times, most recently
from
July 17, 2026 20:27
e4e59fd to
938aec5
Compare
to268
force-pushed
the
fix-cxx-auto-lbrace
branch
from
July 17, 2026 20:27
938aec5 to
03d28e3
Compare
github-project-automation
Bot
moved this from Needs Backport PR
to Done
in LLVM Release Status
Contributor
Author
|
/cherry-pick d592aa5 |
Member
|
/pull-request #210441 |
Contributor
|
Thanks @to268 for the fix. |
dyung
pushed a commit
to llvmbot/llvm-project
that referenced
this pull request
Jul 22, 2026
…#210347) The PR llvm#208552 has introduced a regression where brace initialization was not taken into account `auto foo{12}`. It was also breaking `dcl.type.general` p2 rules, which is also now tested. (cherry picked from commit d592aa5)
to268
added a commit
to to268/llvm-project
that referenced
this pull request
Aug 10, 2026
…ion (llvm#210347)" This reverts commit 9aeb3a9.
to268
added a commit
to to268/llvm-project
that referenced
this pull request
Aug 10, 2026
…on (llvm#210347)" This reverts commit d592aa5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR #208552 has introduced a regression where brace initialization was not taken into account
auto foo{12}. It was also breakingdcl.type.generalp2 rules, which is also now tested.