[Flang-RT] Make implicit PPC intrinsic uses explicit - #206493
Merged
Merged
Conversation
Contributor
|
Thanks for a quick fix. Let me try it. |
Contributor
|
I still various errors in a scratch build. |
Contributor
|
After the fix of the syntax issue, I still see this error: |
Member
Author
kkwli
approved these changes
Jun 29, 2026
kkwli
left a comment
kkwli
left a comment
Contributor
There was a problem hiding this comment.
LG. I tried several scratch builds. The intermittent failure no longer appears. Thanks.
LouisLu060211
pushed a commit
to LouisLu060211/llvm-project
that referenced
this pull request
Jun 30, 2026
The PPC-specific builtin moduls have implicit dependencies insert by flang. For CMake to correctly setup the build order, they must be made explicit. This replicates the implicit module uses from https://github.com/llvm/llvm-project/blob/12b20b36737094b1c521adff0c8f58aaaf2f41fb/flang/lib/Semantics/semantics.cpp#L680-L693 in the modules themselves. The PPC-specific modules compiled by Flang-RT are listed here: https://github.com/llvm/llvm-project/blob/12b20b36737094b1c521adff0c8f58aaaf2f41fb/flang-rt/lib/runtime/CMakeLists.txt#L213-L219 This should fix the intermittend build error mentioned in llvm#205634 (comment). Unfortunately I do not have a PowerPC (cross-)compilation build environment ready to test, nor does the Premerge-CI build it.
maarcosrmz
pushed a commit
to maarcosrmz/llvm-project
that referenced
this pull request
Jul 1, 2026
The PPC-specific builtin moduls have implicit dependencies insert by flang. For CMake to correctly setup the build order, they must be made explicit. This replicates the implicit module uses from https://github.com/llvm/llvm-project/blob/12b20b36737094b1c521adff0c8f58aaaf2f41fb/flang/lib/Semantics/semantics.cpp#L680-L693 in the modules themselves. The PPC-specific modules compiled by Flang-RT are listed here: https://github.com/llvm/llvm-project/blob/12b20b36737094b1c521adff0c8f58aaaf2f41fb/flang-rt/lib/runtime/CMakeLists.txt#L213-L219 This should fix the intermittend build error mentioned in llvm#205634 (comment). Unfortunately I do not have a PowerPC (cross-)compilation build environment ready to test, nor does the Premerge-CI build it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PPC-specific builtin moduls have implicit dependencies insert by flang. For CMake to correctly setup the build order, they must be made explicit.
This replicates the implicit module uses from
llvm-project/flang/lib/Semantics/semantics.cpp
Lines 680 to 693 in 12b20b3
in the modules themselves. The PPC-specific modules compiled by Flang-RT are listed here:
llvm-project/flang-rt/lib/runtime/CMakeLists.txt
Lines 213 to 219 in 12b20b3
This should fix the intermittend build error mentioned in #205634 (comment). Unfortunately I do not have a PowerPC (cross-)compilation build environment ready to test, nor does the Premerge-CI build it.