Skip to content

[X86] Mark AsmPrinter Module Passes as Required#206164

Merged
boomanaiden154 merged 1 commit into
llvm:mainfrom
boomanaiden154:x86-asm-printer-required
Jun 26, 2026
Merged

[X86] Mark AsmPrinter Module Passes as Required#206164
boomanaiden154 merged 1 commit into
llvm:mainfrom
boomanaiden154:x86-asm-printer-required

Conversation

@boomanaiden154

Copy link
Copy Markdown
Contributor

This won't impact them working on optnone functions, but could impact whether or not they get called in opt-bisect, which would be wrong.

This won't impact them working on optnone functions, but could impact
whether or not they get called in opt-bisect, which would be wrong.
@boomanaiden154
boomanaiden154 merged commit 22349e7 into llvm:main Jun 26, 2026
12 of 13 checks passed
@boomanaiden154
boomanaiden154 deleted the x86-asm-printer-required branch June 26, 2026 20:36
@llvmorg-github-actions

Copy link
Copy Markdown

@llvm/pr-subscribers-backend-x86

Author: Aiden Grossman (boomanaiden154)

Changes

This won't impact them working on optnone functions, but could impact whether or not they get called in opt-bisect, which would be wrong.


Full diff: https://github.com/llvm/llvm-project/pull/206164.diff

1 Files Affected:

  • (modified) llvm/lib/Target/X86/X86AsmPrinter.h (+2-2)
diff --git a/llvm/lib/Target/X86/X86AsmPrinter.h b/llvm/lib/Target/X86/X86AsmPrinter.h
index 142b68839501d..450c45e915414 100644
--- a/llvm/lib/Target/X86/X86AsmPrinter.h
+++ b/llvm/lib/Target/X86/X86AsmPrinter.h
@@ -206,7 +206,7 @@ class LLVM_LIBRARY_VISIBILITY X86AsmPrinter : public AsmPrinter {
 };
 
 class X86AsmPrinterBeginPass
-    : public OptionalPassInfoMixin<X86AsmPrinterBeginPass> {
+    : public RequiredPassInfoMixin<X86AsmPrinterBeginPass> {
 public:
   PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM);
 };
@@ -219,7 +219,7 @@ class X86AsmPrinterPass : public RequiredPassInfoMixin<X86AsmPrinterPass> {
 };
 
 class X86AsmPrinterEndPass
-    : public OptionalPassInfoMixin<X86AsmPrinterEndPass> {
+    : public RequiredPassInfoMixin<X86AsmPrinterEndPass> {
 public:
   PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM);
 };

LouisLu060211 pushed a commit to LouisLu060211/llvm-project that referenced this pull request Jun 30, 2026
This won't impact them working on optnone functions, but could impact
whether or not they get called in opt-bisect, which would be wrong.
maarcosrmz pushed a commit to maarcosrmz/llvm-project that referenced this pull request Jul 1, 2026
This won't impact them working on optnone functions, but could impact
whether or not they get called in opt-bisect, which would be wrong.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants