[X86] Mark AsmPrinter Module Passes as Required#206164
Merged
boomanaiden154 merged 1 commit intoJun 26, 2026
Merged
Conversation
This won't impact them working on optnone functions, but could impact whether or not they get called in opt-bisect, which would be wrong.
aeubanks
approved these changes
Jun 26, 2026
|
@llvm/pr-subscribers-backend-x86 Author: Aiden Grossman (boomanaiden154) ChangesThis won't impact them working on optnone functions, but could impact whether or not they get called in opt-bisect, which would be wrong. Full diff: https://github.com/llvm/llvm-project/pull/206164.diff 1 Files Affected:
diff --git a/llvm/lib/Target/X86/X86AsmPrinter.h b/llvm/lib/Target/X86/X86AsmPrinter.h
index 142b68839501d..450c45e915414 100644
--- a/llvm/lib/Target/X86/X86AsmPrinter.h
+++ b/llvm/lib/Target/X86/X86AsmPrinter.h
@@ -206,7 +206,7 @@ class LLVM_LIBRARY_VISIBILITY X86AsmPrinter : public AsmPrinter {
};
class X86AsmPrinterBeginPass
- : public OptionalPassInfoMixin<X86AsmPrinterBeginPass> {
+ : public RequiredPassInfoMixin<X86AsmPrinterBeginPass> {
public:
PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM);
};
@@ -219,7 +219,7 @@ class X86AsmPrinterPass : public RequiredPassInfoMixin<X86AsmPrinterPass> {
};
class X86AsmPrinterEndPass
- : public OptionalPassInfoMixin<X86AsmPrinterEndPass> {
+ : public RequiredPassInfoMixin<X86AsmPrinterEndPass> {
public:
PreservedAnalyses run(Module &M, ModuleAnalysisManager &MAM);
};
|
LouisLu060211
pushed a commit
to LouisLu060211/llvm-project
that referenced
this pull request
Jun 30, 2026
This won't impact them working on optnone functions, but could impact whether or not they get called in opt-bisect, which would be wrong.
maarcosrmz
pushed a commit
to maarcosrmz/llvm-project
that referenced
this pull request
Jul 1, 2026
This won't impact them working on optnone functions, but could impact whether or not they get called in opt-bisect, which would be wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This won't impact them working on optnone functions, but could impact whether or not they get called in opt-bisect, which would be wrong.