Skip to content

[LLVM] Fix a bug in auto upgrading lifetime start/end intrinsics #204601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jurahul merged 1 commit into from
Jun 18, 2026
Merged

[LLVM] Fix a bug in auto upgrading lifetime start/end intrinsics #204601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion llvm/lib/IR/AutoUpgrade.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1556,8 +1556,10 @@ static bool upgradeIntrinsicFunction1(Function *F, Function *&NewFn,
? Intrinsic::lifetime_start
: Intrinsic::lifetime_end;
rename(F);
// Old 2 argument form of these intrinsics have [Size, Ptr] as arguments.
// Use the Ptr argument to create new declaration.
NewFn = Intrinsic::getOrInsertDeclaration(F->getParent(), IID,
F->getArg(0)->getType());
F->getArg(1)->getType());
return true;
}
break;
Expand Down
17 changes: 17 additions & 0 deletions llvm/test/Assembler/autoupgrade-lifetime-intrinsics-invalid-decl.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
; Test to verify that autoupgrade does not end up creating an invalid
; declaration.
; RUN: llvm-as < %s | llvm-dis | FileCheck %s

; CHECK-NOT: declare void @llvm.lifetime.start.i64(i64)
; CHECK-NOT: declare void @llvm.lifetime.end.i64(i64)

define void @tests.lifetime.start.end() {
%a = alloca i8
call void @llvm.lifetime.start(i64 1, ptr %a)
store i8 0, ptr %a
call void @llvm.lifetime.end(i64 1, ptr %a)
ret void
}

declare void @llvm.lifetime.start.p0(i64, ptr)
declare void @llvm.lifetime.end.p0(i64, ptr)