[LLD][ELF] Add missing initialization of Symbol used member.#202578
Merged
Conversation
|
@llvm/pr-subscribers-lld Author: Andrew Ng (nga888) ChangesOn the "main" branch, Symbol no longer has the Full diff: https://github.com/llvm/llvm-project/pull/202578.diff 1 Files Affected:
diff --git a/lld/ELF/Symbols.h b/lld/ELF/Symbols.h
index 23994ccea1ef0..26d28825558c9 100644
--- a/lld/ELF/Symbols.h
+++ b/lld/ELF/Symbols.h
@@ -243,11 +243,11 @@ class Symbol {
uint8_t stOther, uint8_t type)
: file(file), nameData(name.data()), nameSize(name.size()), type(type),
binding(binding), stOther(stOther), symbolKind(k), isPreemptible(false),
- isUsedInRegularObj(false), isExported(false), ltoCanOmit(false),
- traced(false), hasVersionSuffix(false), isInIplt(false),
- gotInIgot(false), folded(false), archSpecificBit(false),
- scriptDefined(false), dsoDefined(false), dsoProtected(false),
- versionScriptAssigned(false), thunkAccessed(false),
+ isUsedInRegularObj(false), used(false), isExported(false),
+ ltoCanOmit(false), traced(false), hasVersionSuffix(false),
+ isInIplt(false), gotInIgot(false), folded(false),
+ archSpecificBit(false), scriptDefined(false), dsoDefined(false),
+ dsoProtected(false), versionScriptAssigned(false), thunkAccessed(false),
inDynamicList(false), referenced(false), referencedAfterWrap(false) {}
void overwrite(Symbol &sym, Kind k) const {
|
|
@llvm/pr-subscribers-lld-elf Author: Andrew Ng (nga888) ChangesOn the "main" branch, Symbol no longer has the Full diff: https://github.com/llvm/llvm-project/pull/202578.diff 1 Files Affected:
diff --git a/lld/ELF/Symbols.h b/lld/ELF/Symbols.h
index 23994ccea1ef0..26d28825558c9 100644
--- a/lld/ELF/Symbols.h
+++ b/lld/ELF/Symbols.h
@@ -243,11 +243,11 @@ class Symbol {
uint8_t stOther, uint8_t type)
: file(file), nameData(name.data()), nameSize(name.size()), type(type),
binding(binding), stOther(stOther), symbolKind(k), isPreemptible(false),
- isUsedInRegularObj(false), isExported(false), ltoCanOmit(false),
- traced(false), hasVersionSuffix(false), isInIplt(false),
- gotInIgot(false), folded(false), archSpecificBit(false),
- scriptDefined(false), dsoDefined(false), dsoProtected(false),
- versionScriptAssigned(false), thunkAccessed(false),
+ isUsedInRegularObj(false), used(false), isExported(false),
+ ltoCanOmit(false), traced(false), hasVersionSuffix(false),
+ isInIplt(false), gotInIgot(false), folded(false),
+ archSpecificBit(false), scriptDefined(false), dsoDefined(false),
+ dsoProtected(false), versionScriptAssigned(false), thunkAccessed(false),
inDynamicList(false), referenced(false), referencedAfterWrap(false) {}
void overwrite(Symbol &sym, Kind k) const {
|
Member
|
Can you reference the commit that removed |
nga888
force-pushed
the
fix-uninitialised-symbol-used
branch
from
June 9, 2026 16:21
e1751aa to
804ab24
Compare
Contributor
Author
I've updated the commit message and PR description as requested. |
github-project-automation
Bot
moved this from Needs Triage
to Needs Merge
in LLVM Release Status
MaskRay
approved these changes
Jun 9, 2026
On the "main" branch, Symbol no longer has the `used` member which was moved in PR llvm#190117 (commit 6a87416). Therefore, when the cherry pick from PR llvm#198129 (commit 905a88b) was merged to the "release/22.x" branch, the initialization of `used` was lost.
dyung
force-pushed
the
fix-uninitialised-symbol-used
branch
from
June 10, 2026 17:50
804ab24 to
070e505
Compare
github-project-automation
Bot
moved this from Needs Merge
to Done
in LLVM Release Status
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the "main" branch, Symbol no longer has the
usedmember which was moved in PR #190117 (commit 6a87416). Therefore, when the cherry pick from PR #198129 (commit 905a88b) was merged to the "release/22.x" branch, the initialization ofusedwas lost.