Skip to content

[lldb-dap] Cleanup InstructionBreakpoint #200228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DrSergei merged 1 commit into from
Jun 1, 2026
Merged

[lldb-dap] Cleanup InstructionBreakpoint #200228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions lldb/tools/lldb-dap/InstructionBreakpoint.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,14 +18,16 @@ namespace lldb_dap {
InstructionBreakpoint::InstructionBreakpoint(
DAP &d, const protocol::InstructionBreakpoint &breakpoint)
: Breakpoint(d, breakpoint.condition, breakpoint.hitCondition),
m_instruction_address_reference(LLDB_INVALID_ADDRESS),
m_offset(breakpoint.offset.value_or(0)) {
m_instruction_address_reference(LLDB_INVALID_ADDRESS) {
llvm::StringRef instruction_reference(breakpoint.instructionReference);
instruction_reference.getAsInteger(0, m_instruction_address_reference);
m_instruction_address_reference += m_offset;
m_instruction_address_reference += breakpoint.offset.value_or(0);
}

void InstructionBreakpoint::SetBreakpoint() {
lldb::SBMutex lock = m_dap.GetAPIMutex();
std::lock_guard<lldb::SBMutex> guard(lock);

m_bp =
m_dap.target.BreakpointCreateByAddress(m_instruction_address_reference);
Breakpoint::SetBreakpoint();
Expand Down
1 change: 0 additions & 1 deletion lldb/tools/lldb-dap/InstructionBreakpoint.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ class InstructionBreakpoint : public Breakpoint {

protected:
lldb::addr_t m_instruction_address_reference;
int32_t m_offset;
};

} // namespace lldb_dap
Expand Down