-
Notifications
You must be signed in to change notification settings - Fork 18k
[libc] introduce shared compiler-rt builtins #200094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
| /// | ||
| /// \file | ||
| /// This header aggregates LLVM-libc's shared compiler-rt builtins so that | ||
| /// they can be reused by compiler-rt's builtins. | ||
| /// | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef LLVM_LIBC_SHARED_BUILTINS_H | ||
| #define LLVM_LIBC_SHARED_BUILTINS_H | ||
|
|
||
| #include "libc_common.h" | ||
|
|
||
| #include "builtins/addtf3.h" | ||
|
|
||
| #endif // LLVM_LIBC_SHARED_BUILTINS_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
| /// | ||
| /// \file | ||
| /// This header exposes LLVM-libc's __addtf3 implementation as shared::addtf3 | ||
| /// so that it can be reused by compiler-rt's builtins. | ||
| /// | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef LLVM_LIBC_SHARED_BUILTINS_ADDTF3_H | ||
| #define LLVM_LIBC_SHARED_BUILTINS_ADDTF3_H | ||
|
|
||
| #include "include/llvm-libc-types/float128.h" | ||
|
|
||
| #ifdef LIBC_TYPES_HAS_FLOAT128 | ||
|
|
||
| #include "shared/libc_common.h" | ||
| #include "src/__support/builtins/addtf3.h" | ||
|
|
||
| namespace LIBC_NAMESPACE_DECL { | ||
| namespace shared { | ||
|
|
||
| using builtins::addtf3; | ||
|
|
||
| } // namespace shared | ||
| } // namespace LIBC_NAMESPACE_DECL | ||
|
|
||
| #endif // LIBC_TYPES_HAS_FLOAT128 | ||
|
|
||
| #endif // LLVM_LIBC_SHARED_BUILTINS_ADDTF3_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| add_header_library( | ||
| addtf3 | ||
| HDRS | ||
| addtf3.h | ||
| DEPENDS | ||
| libc.include.llvm-libc-types.float128 | ||
| libc.src.__support.FPUtil.generic.add_sub | ||
| libc.src.__support.macros.config | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,38 @@ | ||
| //===----------------------------------------------------------------------===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
| /// | ||
| /// \file | ||
| /// This header exposes LLVM-libc's __addtf3 implementation as | ||
| /// builtins::addtf3 so that it can be reused by compiler-rt's builtins. | ||
| /// | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #ifndef LLVM_LIBC_SRC___SUPPORT_BUILTINS_ADDTF3_H | ||
| #define LLVM_LIBC_SRC___SUPPORT_BUILTINS_ADDTF3_H | ||
|
|
||
| #include "include/llvm-libc-types/float128.h" | ||
|
|
||
| #ifdef LIBC_TYPES_HAS_FLOAT128 | ||
|
|
||
| #include "src/__support/FPUtil/generic/add_sub.h" | ||
| #include "src/__support/macros/config.h" | ||
|
|
||
| namespace LIBC_NAMESPACE_DECL { | ||
| namespace builtins { | ||
|
|
||
| // Mirrors the compiler-rt __addtf3 ABI: a + b at float128 precision. | ||
| LIBC_INLINE float128 addtf3(float128 x, float128 y) { | ||
| return fputil::generic::add<float128>(x, y); | ||
| } | ||
|
|
||
| } // namespace builtins | ||
| } // namespace LIBC_NAMESPACE_DECL | ||
|
|
||
| #endif // LIBC_TYPES_HAS_FLOAT128 | ||
|
|
||
| #endif // LLVM_LIBC_SRC___SUPPORT_BUILTINS_ADDTF3_H |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| //===-- Unittests for shared builtins -------------------------------------===// | ||
| // | ||
| // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. | ||
| // See https://llvm.org/LICENSE.txt for license information. | ||
| // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception | ||
| // | ||
| //===----------------------------------------------------------------------===// | ||
|
|
||
| #include "shared/builtins.h" | ||
| #include "test/UnitTest/FPMatcher.h" | ||
| #include "test/UnitTest/Test.h" | ||
|
|
||
| TEST(LlvmLibcSharedBuiltinsTest, AllFloat) { | ||
| // TODO: assertions for shared::*sf3 builtins. | ||
|
hulxv marked this conversation as resolved.
|
||
| } | ||
|
|
||
| TEST(LlvmLibcSharedBuiltinsTest, AllDouble) { | ||
| // TODO: assertions for shared::*df3 builtins. | ||
| } | ||
|
|
||
| #ifdef LIBC_TYPES_HAS_FLOAT128 | ||
|
|
||
| TEST(LlvmLibcSharedBuiltinsTest, AllFloat128) { | ||
| namespace shared = LIBC_NAMESPACE::shared; | ||
|
|
||
| EXPECT_FP_EQ(float128(3.0), shared::addtf3(float128(1.0), float128(2.0))); | ||
| } | ||
|
|
||
| #endif // LIBC_TYPES_HAS_FLOAT128 | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.