[cmake][runtimes] Pass variable type for passthrough CMake options - #198505
Conversation
d3c0e65 to
2ac653c
Compare
Passing the types affects the handling of `PATH` cache variables. The motivating case is setting `COMPILER_RT_INSTALL_LIBRARY_DIR` without `CMAKE_BINARY_DIR` getting prepended to it.
2ac653c to
f936a31
Compare
|
Looks like this broke our toolchain build with the following error: You can see the full log here https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8681299599353914865/+/u/clang/build/stdout Would it be possible to revert? |
|
@petrhosek Revert in #198739. I see nothing obvious in Would you be able to provide a zipped |
…tions" (#198739) Reverts #198505 per breakage reported in #198505 (comment)
…gh CMake options" (#198739) Reverts llvm/llvm-project#198505 per breakage reported in llvm/llvm-project#198505 (comment)
…gh CMake options" (#198739) Reverts llvm/llvm-project#198505 per breakage reported in llvm/llvm-project#198505 (comment)
…gh CMake options" (#198739) Reverts llvm/llvm-project#198505 per breakage reported in llvm/llvm-project#198505 (comment)
|
@petrhosek Ping. I don't want to break your downstream out-of-tree things but I also don't have a way to debug that. |
Depends on #198505 and #198506.
Passing the types affects the handling of
PATHcache variables.The motivating case is setting
COMPILER_RT_INSTALL_LIBRARY_DIRwithoutCMAKE_BINARY_DIRgetting prepended to it.