Skip to content

[cmake][runtimes] Pass variable type for passthrough CMake options - #198505

Merged
tambry merged 1 commit into
llvm:mainfrom
tambry:runtimes_passthrough_options_type
May 20, 2026
Merged

[cmake][runtimes] Pass variable type for passthrough CMake options#198505
tambry merged 1 commit into
llvm:mainfrom
tambry:runtimes_passthrough_options_type

Conversation

@tambry

@tambry tambry commented May 19, 2026

Copy link
Copy Markdown
Contributor

Depends on #198505 and #198506.


Passing the types affects the handling of PATH cache variables.
The motivating case is setting COMPILER_RT_INSTALL_LIBRARY_DIR without CMAKE_BINARY_DIR getting prepended to it.

@tambry tambry self-assigned this May 19, 2026
@tambry tambry added the cmake Build system in general and CMake in particular label May 19, 2026
@tambry
tambry force-pushed the runtimes_passthrough_options_type branch from d3c0e65 to 2ac653c Compare May 20, 2026 06:39
@tambry
tambry marked this pull request as ready for review May 20, 2026 06:39
@tambry
tambry requested review from jhuber6 and petrhosek May 20, 2026 06:39
Passing the types affects the handling of `PATH` cache variables.
The motivating case is setting `COMPILER_RT_INSTALL_LIBRARY_DIR` without `CMAKE_BINARY_DIR` getting prepended to it.
@tambry
tambry force-pushed the runtimes_passthrough_options_type branch from 2ac653c to f936a31 Compare May 20, 2026 07:03
@tambry
tambry merged commit 2e06e00 into llvm:main May 20, 2026
10 checks passed
@tambry
tambry deleted the runtimes_passthrough_options_type branch May 20, 2026 07:50
@petrhosek

Copy link
Copy Markdown
Member

Looks like this broke our toolchain build with the following error:

CMake Error in /Users/swarming/b/s/w/ir/x/w/llvm-llvm-project/libcxx/src/CMakeLists.txt:
  No known features for CXX compiler

  "Clang"

  version 23.0.0.


CMake Generate step failed.  Build files cannot be regenerated correctly.

You can see the full log here https://logs.chromium.org/logs/fuchsia/buildbucket/cr-buildbucket/8681299599353914865/+/u/clang/build/stdout

Would it be possible to revert?

@tambry

tambry commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

@petrhosek Revert in #198739. I see nothing obvious in Fuchsia-stage2.cmake that could break in combination with this change.

Would you be able to provide a zipped /Users/swarming/b/s/w/ir/x/w/llvm_build/runtimes/runtimes-x86_64-pc-windows-msvc-bins from the buildbot after failure? Or at least CMakeCache.txt and CMakeFiles/CMakeConfigureLog.yaml? I lack any Windows machines or an appropriate sysroot to reproduce locally. The Fuchsia IDK doesn't seem sufficient.

petrhosek pushed a commit that referenced this pull request May 20, 2026
llvm-upstreamsync Bot pushed a commit to qualcomm/cpullvm-toolchain that referenced this pull request May 20, 2026
llvm-sync Bot pushed a commit to arm/arm-toolchain that referenced this pull request May 20, 2026
cpullvm-upstream-sync Bot pushed a commit to navaneethshan/cpullvm-toolchain-1 that referenced this pull request May 20, 2026
@tambry

tambry commented Jun 4, 2026

Copy link
Copy Markdown
Contributor Author

@petrhosek Ping. I don't want to break your downstream out-of-tree things but I also don't have a way to debug that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cmake Build system in general and CMake in particular

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants