[clang][modules-driver] Further constrain import-std test - #194604
Merged
Conversation
The root cause for the failing test was found in llvm#194475 (comment). The test uses --target=x86_64-linux-gnu which is only available with -DLLVM_TARGETS_TO_BUILD=all or on native x86 targets.
llvmbot
added
clang
Member
|
@llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Naveen Seth Hanig (naveen-seth) ChangesThe root cause for the failing test was found in #194475 (comment). Full diff: https://github.com/llvm/llvm-project/pull/194604.diff 1 Files Affected:
diff --git a/clang/test/Driver/modules-driver-import-std.cpp b/clang/test/Driver/modules-driver-import-std.cpp
index 394b0dc8d95d3..3a51cab0406b2 100644
--- a/clang/test/Driver/modules-driver-import-std.cpp
+++ b/clang/test/Driver/modules-driver-import-std.cpp
@@ -1,8 +1,7 @@
// Checks that -fmodules-driver correctly handles the import of Standard library
// modules.
-// https://github.com/llvm/llvm-project/pull/194475#issuecomment-4331347690
-// UNSUPPORTED: target={{.*}}aarch64{{.*}}, {{.*}}arm64{{.*}}
+// REQUIRES: x86-registered-target
// The standard library modules manifest (libc++.modules.json) is discovered
// relative to the installed C++ standard library runtime libraries
|
Contributor
Author
|
Sorry for the breakage! I think this should fully fix it now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause for the failing test was found in #194475 (comment).
The test uses
--target=x86_64-linux-gnuwhich is only available with-DLLVM_TARGETS_TO_BUILD=allor on native x86 targets.