Skip to content

[CtxProf] emit fatal usage error when flatten-prethinlink runs without guid metadata #194383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boomanaiden154 merged 3 commits into from
Jun 17, 2026
Merged

[CtxProf] emit fatal usage error when flatten-prethinlink runs without guid metadata #194383

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c0a9881
[CtxProf] emit fatal usage error when flatten-prethinlink runs withou…
pektezol Apr 27, 2026
833e4c9
[CtxProf][NFC] update usage error message
pektezol Jun 17, 2026
6163f75
[CtxProf][NFC] update testcase check
pektezol Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion llvm/lib/Analysis/CtxProfAnalysis.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -441,7 +441,9 @@ GlobalValue::GUID AssignGUIDPass::getGUID(const Function &F) {
return F.getGUID();
}
auto *MD = F.getMetadata(GUIDMetadataName);
assert(MD && "guid not found for defined function");
if (!MD)
reportFatalUsageError(
"this pass requires the GUID metadata to be available.");
Comment thread
pektezol marked this conversation as resolved.
Outdated
return cast<ConstantInt>(cast<ConstantAsMetadata>(MD->getOperand(0))
->getValue()
->stripPointerCasts())
Expand Down
7 changes: 7 additions & 0 deletions llvm/test/Analysis/CtxProfAnalysis/flatten-prethinlink-requires-guid-metadata.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
; RUN: not opt -passes='ctx-prof-flatten-prethinlink' %s -disable-output 2>&1 | FileCheck %s

; CHECK: LLVM ERROR: this pass requires the GUID metadata to be available.

define void @test() {
ret void
}