Skip to content

[GlobalISel] use constexpr LLT types when creating ISel data #191574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michalpaszkowski merged 1 commit into from
Apr 14, 2026
Merged

[GlobalISel] use constexpr LLT types when creating ISel data #191574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions llvm/test/TableGen/GlobalISelEmitter/GlobalISelEmitter.td
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,8 +117,8 @@ def HasC : Predicate<"Subtarget->hasC()"> { let RecomputePerFunction = 1; }
// EXTENDED-NEXT: };
// EXTENDED-NEXT: const static size_t NumTypeObjects = 3;
// EXTENDED-NEXT: const static LLT TypeObjects[] = {
// EXTENDED-NEXT: LLT::integer(32),
// EXTENDED-NEXT: LLT::floatIEEE(32),
// EXTENDED-NEXT: LLT(LLT::Kind::INTEGER, ElementCount::getFixed(0), 32),
// EXTENDED-NEXT: LLT(LLT::Kind::FLOAT, ElementCount::getFixed(0), 32, LLT::FpSemantics::S_IEEEsingle),
// EXTENDED-NEXT: LLT::pointer(0, 32),
// EXTENDED-NEXT: };

Expand Down
57 changes: 31 additions & 26 deletions llvm/utils/TableGen/Common/GlobalISel/GlobalISelMatchTable.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,19 +409,37 @@ void LLTCodeGen::emitCxxEnumValue(raw_ostream &OS) const {
}

void LLTCodeGen::emitCxxConstructorCall(raw_ostream &OS) const {
if (Ty.isScalar()) {
if (Ty.isInteger())
OS << "LLT::integer(" << Ty.getScalarSizeInBits() << ")";
else if (Ty.isBFloat16())
OS << "LLT::bfloat16()";
else if (Ty.isPPCF128())
OS << "LLT::ppcf128()";
else if (Ty.isX86FP80())
OS << "LLT::x86fp80()";
else if (Ty.isFloat())
OS << "LLT::floatIEEE(" << Ty.getScalarSizeInBits() << ")";
auto EmitScalarType = [&OS](LLT T) {
if (T.isInteger())
OS << "LLT(LLT::Kind::INTEGER, ElementCount::getFixed(0), "

@davemgreen davemgreen Apr 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Create a lambda that prints the LLT type and reuse it for vector elements too?

<< T.getScalarSizeInBits() << ")";
else if (T.isBFloat16())
OS << "LLT(LLT::Kind::FLOAT, ElementCount::getFixed(0), 16, "
"LLT::FpSemantics::S_BFloat)";
else if (T.isPPCF128())
OS << "LLT(LLT::Kind::FLOAT, ElementCount::getFixed(0), 128, "
"LLT::FpSemantics::S_PPCDoubleDouble)";
else if (T.isX86FP80())
OS << "LLT(LLT::Kind::FLOAT, ElementCount::getFixed(0), 80, "
"LLT::FpSemantics::S_x87DoubleExtended)";
else if (T.isFloat(16))
OS << "LLT(LLT::Kind::FLOAT, ElementCount::getFixed(0), 16, "
"LLT::FpSemantics::S_IEEEhalf)";
else if (T.isFloat(32))
OS << "LLT(LLT::Kind::FLOAT, ElementCount::getFixed(0), 32, "
"LLT::FpSemantics::S_IEEEsingle)";
else if (T.isFloat(64))
OS << "LLT(LLT::Kind::FLOAT, ElementCount::getFixed(0), 64, "
"LLT::FpSemantics::S_IEEEdouble)";
else if (T.isFloat(128))
OS << "LLT(LLT::Kind::FLOAT, ElementCount::getFixed(0), 128, "
"LLT::FpSemantics::S_IEEEquad)";
else
OS << "LLT::scalar(" << Ty.getScalarSizeInBits() << ")";
OS << "LLT::scalar(" << T.getScalarSizeInBits() << ")";
};

if (Ty.isScalar()) {
EmitScalarType(Ty);
return;
}

Expand All @@ -430,20 +448,7 @@ void LLTCodeGen::emitCxxConstructorCall(raw_ostream &OS) const {
<< (Ty.isScalable() ? "ElementCount::getScalable("
: "ElementCount::getFixed(")
<< Ty.getElementCount().getKnownMinValue() << "), ";

LLT ElemTy = Ty.getElementType();
if (ElemTy.isInteger())
OS << "LLT::integer(" << ElemTy.getScalarSizeInBits() << ")";
else if (ElemTy.isBFloat16())
OS << "LLT::bfloat16()";
else if (ElemTy.isPPCF128())
OS << "LLT::ppcf128()";
else if (ElemTy.isX86FP80())
OS << "LLT::x86fp80()";
else if (ElemTy.isFloat())
OS << "LLT::floatIEEE(" << ElemTy.getScalarSizeInBits() << ")";
else
OS << "LLT::scalar(" << Ty.getScalarSizeInBits() << ")";
EmitScalarType(Ty.getElementType());
OS << ")";
return;
}
Expand Down