Skip to content

[lld] Add missing include in AArch64ErrataFix (NFC) - #190664

Merged
keith merged 1 commit into
llvm:mainfrom
keith:ks/lld-add-missing-include-in-aarch64erratafix-nfc
Apr 13, 2026
Merged

keith merged 1 commit into
llvm:mainfrom
keith:ks/lld-add-missing-include-in-aarch64erratafix-nfc

Conversation

@keith

@keith keith commented Apr 6, 2026

Copy link
Copy Markdown
Member

This header assumed SmallVector would be included before it

This header assumed SmallVector would be included before it
@llvmbot

llvmbot commented Apr 6, 2026

Copy link
Copy Markdown
Member

@llvm/pr-subscribers-lld-elf

@llvm/pr-subscribers-lld

Author: Keith Smiley (keith)

Changes

This header assumed SmallVector would be included before it


Full diff: https://github.com/llvm/llvm-project/pull/190664.diff

1 Files Affected:

  • (modified) lld/ELF/AArch64ErrataFix.h (+1)
diff --git a/lld/ELF/AArch64ErrataFix.h b/lld/ELF/AArch64ErrataFix.h
index 8e0d305eb9ccd..0a81b615fb122 100644
--- a/lld/ELF/AArch64ErrataFix.h
+++ b/lld/ELF/AArch64ErrataFix.h
@@ -11,6 +11,7 @@
 
 #include "lld/Common/LLVM.h"
 #include "llvm/ADT/DenseMap.h"
+#include "llvm/ADT/SmallVector.h"
 #include <vector>
 
 namespace lld::elf {

@smithp35 smithp35 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me given the LLVM policy on header files should be self contained. https://llvm.org/docs/CodingStandards.html#self-contained-headers

Header files should be self-contained (compile on their own) and end in .h. Non-header files that are meant for inclusion should end in .inc and be used sparingly.

At the moment it looks like InputFiles.cpp includes lld/ELF/config.h which includes SmallVector.h.

@keith
keith merged commit f285a55 into llvm:main Apr 13, 2026
13 checks passed
@keith
keith deleted the ks/lld-add-missing-include-in-aarch64erratafix-nfc branch April 13, 2026 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants