[lld] Add missing include in AArch64ErrataFix (NFC) - #190664
Merged
keith merged 1 commit intoApr 13, 2026
Merged
Conversation
This header assumed SmallVector would be included before it
Member
|
@llvm/pr-subscribers-lld-elf @llvm/pr-subscribers-lld Author: Keith Smiley (keith) ChangesThis header assumed SmallVector would be included before it Full diff: https://github.com/llvm/llvm-project/pull/190664.diff 1 Files Affected:
diff --git a/lld/ELF/AArch64ErrataFix.h b/lld/ELF/AArch64ErrataFix.h
index 8e0d305eb9ccd..0a81b615fb122 100644
--- a/lld/ELF/AArch64ErrataFix.h
+++ b/lld/ELF/AArch64ErrataFix.h
@@ -11,6 +11,7 @@
#include "lld/Common/LLVM.h"
#include "llvm/ADT/DenseMap.h"
+#include "llvm/ADT/SmallVector.h"
#include <vector>
namespace lld::elf {
|
smithp35
approved these changes
Apr 13, 2026
smithp35
left a comment
Contributor
There was a problem hiding this comment.
This looks good to me given the LLVM policy on header files should be self contained. https://llvm.org/docs/CodingStandards.html#self-contained-headers
Header files should be self-contained (compile on their own) and end in .h. Non-header files that are meant for inclusion should end in .inc and be used sparingly.
At the moment it looks like InputFiles.cpp includes lld/ELF/config.h which includes SmallVector.h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This header assumed SmallVector would be included before it