Skip to content

[libc++] Specify encoding='utf-8' in conformance script #189534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ldionne merged 1 commit into from
Jun 26, 2026
Merged

[libc++] Specify encoding='utf-8' in conformance script #189534

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions libcxx/utils/conformance
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,8 +496,8 @@ def github_link(issues, meeting_voted, status):
link_github_issue(issue, meeting_voted, status)

@github_cmd.command('create')
@click.argument('csvfiles', nargs=-1, type=click.File('r'))
@click.option('--load-github-from', type=click.File('r'), required=False,
@click.argument('csvfiles', nargs=-1, type=click.File('r', encoding='utf-8'))
@click.option('--load-github-from', type=click.File('r', encoding='utf-8'), required=False,
help='Optionally load the Github Conformance tracking data from the given file. Useful to avoid '
'running into API call limits when testing locally. See `conformance github download`.')
@click.option('--labels', type=str, multiple=True,
Expand Down Expand Up @@ -565,7 +565,7 @@ def github_create(csvfiles, load_github_from, labels):


@github_cmd.command('download')
@click.option('--output', '-o', type=click.File('w'), default='-',
@click.option('--output', '-o', type=click.File('w', encoding='utf-8'), default='-',
help='Save the data to the provided file. Default is stdout.')
def github_download(output):
"""Download libc++ conformance tracking data from Github issues and save it locally."""
Expand All @@ -580,7 +580,7 @@ def csv_cmd():


@csv_cmd.command('validate')
@click.argument('files', nargs=-1, type=click.File('r'))
@click.argument('files', nargs=-1, type=click.File('r', encoding='utf-8'))
def csv_validate(files):
"""Validate the format of the provided CSV files."""
for file in files:
Expand All @@ -591,10 +591,10 @@ def csv_validate(files):


@csv_cmd.command('synchronize')
@click.argument('files', nargs=-1, type=click.File('r'))
@click.option('--output', '-o', type=click.File('w'), default='-',
@click.argument('files', nargs=-1, type=click.File('r', encoding='utf-8'))
@click.option('--output', '-o', type=click.File('w', encoding='utf-8'), default='-',
help='Write the generated CSV to the specified file. Defaults to stdout.')
@click.option('--load-github-from', type=click.File('r'), required=False,
@click.option('--load-github-from', type=click.File('r', encoding='utf-8'), required=False,
help='Optionally load the Github Conformance tracking data from the given file. Useful to avoid '
'running into API call limits when testing locally. See `conformance github download`.')
def csv_synchronize(files, output, load_github_from):
Expand All @@ -615,9 +615,9 @@ def csv_synchronize(files, output, load_github_from):

@csv_cmd.command('create')
@click.argument('issues', nargs=-1)
@click.option('--output', '-o', type=click.File('w'), default='-',
@click.option('--output', '-o', type=click.File('w', encoding='utf-8'), default='-',
help='Write the generated CSV to the specified file. Defaults to stdout.')
@click.option('--load-github-from', type=click.File('r'), required=False,
@click.option('--load-github-from', type=click.File('r', encoding='utf-8'), required=False,
help='Optionally load the Github Conformance tracking data from the given file. Useful to avoid '
'running into API call limits when testing locally. See `conformance github download`.')
def csv_create(issues, output, load_github_from):
Expand Down
Loading