Skip to content

[Mips] Correctly report sizes for PATCHABLE_* #188229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nikic merged 2 commits into from
Apr 1, 2026
+11 −0
Merged

[Mips] Correctly report sizes for PATCHABLE_* #188229

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b72eae
[Mips] Correctly report sizes for PATCHABLE_*
nikic Mar 24, 2026
883ff1d
Add comments
nikic Apr 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions llvm/lib/Target/Mips/MipsInstrInfo.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,6 +714,17 @@ unsigned MipsInstrInfo::getInstSizeInBytes(const MachineInstr &MI) const {
const char *AsmStr = MI.getOperand(0).getSymbolName();
return getInlineAsmLength(AsmStr, *MF->getTarget().getMCAsmInfo());
}
case TargetOpcode::PATCHABLE_FUNCTION_ENTER:
case TargetOpcode::PATCHABLE_FUNCTION_EXIT:
case TargetOpcode::PATCHABLE_TAIL_CALL:
// Size of xray sled
if (Subtarget.isGP64bit()) {
// beq + 15 nops
return 16 * 4;
} else {
// beq + 11 nops + addiu
return 13 * 4;

@yingopq yingopq Apr 1, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some comments regarding the numbers?

@nikic nikic Apr 1, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

}
case Mips::CONSTPOOL_ENTRY:
// If this machine instr is a constant pool entry, its size is recorded as
// operand #2.
Expand Down