[lldb][bytecode] Compile pick ops using unsigned literal - #187376
Merged
kastiglione merged 2 commits intoMar 18, 2026
Merged
Conversation
Member
|
@llvm/pr-subscribers-lldb Author: Dave Lee (kastiglione) ChangesFull diff: https://github.com/llvm/llvm-project/pull/187376.diff 1 Files Affected:
diff --git a/lldb/examples/python/formatter_bytecode.py b/lldb/examples/python/formatter_bytecode.py
index e825110356ff6..da114a964f55c 100644
--- a/lldb/examples/python/formatter_bytecode.py
+++ b/lldb/examples/python/formatter_bytecode.py
@@ -1059,14 +1059,14 @@ def visit_Attribute(self, node: ast.Attribute) -> None:
)
attr_idx = self._attr_index(node.attr, node)
pick_idx = self.num_temps + attr_idx
- self._output(f"{pick_idx} pick") # "# self.{node.attr}"
+ self._output(f"{pick_idx}u pick") # "# self.{node.attr}"
self.num_temps += 1
def visit_Name(self, node: ast.Name) -> None:
idx = self._stack_index(node)
if idx is None:
raise CompilerError(f"unknown local variable: {node.id}", node)
- self._output(f"{idx} pick") # "# {node.id}"
+ self._output(f"{idx}u pick") # "# {node.id}"
self.num_temps += 1
def _visit_each(self, nodes: Sequence[ast.AST]) -> None:
|
🐧 Linux x64 Test Results
✅ The build succeeded and all tests passed. |
kastiglione
deleted the
lldb-bytecode-Compile-pick-ops-using-unsigned-literal
branch
March 18, 2026 21:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pickop requires an unsigned integer index. Use theusuffix when generatingpickoperations in the Python->formatter-bytecode compiler.