Skip to content

[MLIR][Python] Add optional emit reset to exportSMTLIB #187366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RattataKing merged 1 commit into from
Mar 18, 2026
Merged

[MLIR][Python] Add optional emit reset to exportSMTLIB #187366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions mlir/include/mlir-c/Target/ExportSMTLIB.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,13 @@ extern "C" {

/// Emits SMTLIB for the specified module using the provided callback and user
/// data
MLIR_CAPI_EXPORTED MlirLogicalResult
mlirTranslateModuleToSMTLIB(MlirModule, MlirStringCallback, void *userData,
bool inlineSingleUseValues, bool indentLetBody);
MLIR_CAPI_EXPORTED MlirLogicalResult mlirTranslateModuleToSMTLIB(
MlirModule, MlirStringCallback, void *userData, bool inlineSingleUseValues,
bool indentLetBody, bool emitReset);

MLIR_CAPI_EXPORTED MlirLogicalResult mlirTranslateOperationToSMTLIB(
MlirOperation, MlirStringCallback, void *userData,
bool inlineSingleUseValues, bool indentLetBody);
bool inlineSingleUseValues, bool indentLetBody, bool emitReset);

#ifdef __cplusplus
}
Expand Down
2 changes: 2 additions & 0 deletions mlir/include/mlir/Target/SMTLIB/ExportSMTLIB.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ struct SMTEmissionOptions {
bool inlineSingleUseValues = false;
// Increase indentation for each 'let' expression body.
bool indentLetBody = false;
// Emit a '(reset)' command at the end of each solver scope.
bool emitReset = true;
};

/// Run the ExportSMTLIB pass.
Expand Down
17 changes: 9 additions & 8 deletions mlir/lib/Bindings/Python/DialectSMT.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,12 +91,12 @@ static void populateDialectSMTSubmodule(nanobind::module_ &m) {
IntType::bind(m);

auto exportSMTLIB = [](MlirOperation module, bool inlineSingleUseValues,
bool indentLetBody) {
bool indentLetBody, bool emitReset) {
CollectDiagnosticsToStringScope scope(mlirOperationGetContext(module));
PyPrintAccumulator printAccum;
MlirLogicalResult result = mlirTranslateOperationToSMTLIB(
module, printAccum.getCallback(), printAccum.getUserData(),
inlineSingleUseValues, indentLetBody);
inlineSingleUseValues, indentLetBody, emitReset);
if (mlirLogicalResultIsSuccess(result))
return printAccum.join();
throw nb::value_error(
Expand All @@ -107,20 +107,21 @@ static void populateDialectSMTSubmodule(nanobind::module_ &m) {
m.def(
"export_smtlib",
[&exportSMTLIB](const PyOperation &module, bool inlineSingleUseValues,
bool indentLetBody) {
return exportSMTLIB(module, inlineSingleUseValues, indentLetBody);
bool indentLetBody, bool emitReset) {
return exportSMTLIB(module, inlineSingleUseValues, indentLetBody,
emitReset);
},
"module"_a, "inline_single_use_values"_a = false,
"indent_let_body"_a = false);
"indent_let_body"_a = false, "emit_reset"_a = true);
m.def(
"export_smtlib",
[&exportSMTLIB](PyModule &module, bool inlineSingleUseValues,
bool indentLetBody) {
bool indentLetBody, bool emitReset) {
return exportSMTLIB(mlirModuleGetOperation(module.get()),
inlineSingleUseValues, indentLetBody);
inlineSingleUseValues, indentLetBody, emitReset);
},
"module"_a, "inline_single_use_values"_a = false,
"indent_let_body"_a = false);
"indent_let_body"_a = false, "emit_reset"_a = true);
}
} // namespace smt
} // namespace MLIR_BINDINGS_PYTHON_DOMAIN
Expand Down
26 changes: 12 additions & 14 deletions mlir/lib/CAPI/Target/ExportSMTLIB.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,24 +19,22 @@

using namespace mlir;

MlirLogicalResult mlirTranslateOperationToSMTLIB(MlirOperation module,
MlirStringCallback callback,
void *userData,
bool inlineSingleUseValues,
bool indentLetBody) {
MlirLogicalResult mlirTranslateOperationToSMTLIB(
MlirOperation module, MlirStringCallback callback, void *userData,
bool inlineSingleUseValues, bool indentLetBody, bool emitReset) {
mlir::detail::CallbackOstream stream(callback, userData);
smt::SMTEmissionOptions options;
options.inlineSingleUseValues = inlineSingleUseValues;
options.indentLetBody = indentLetBody;
return wrap(smt::exportSMTLIB(unwrap(module), stream));
options.emitReset = emitReset;
return wrap(smt::exportSMTLIB(unwrap(module), stream, options));
}

MlirLogicalResult mlirTranslateModuleToSMTLIB(MlirModule module,
MlirStringCallback callback,
void *userData,
bool inlineSingleUseValues,
bool indentLetBody) {
return mlirTranslateOperationToSMTLIB(mlirModuleGetOperation(module),
callback, userData,
inlineSingleUseValues, indentLetBody);
MlirLogicalResult
mlirTranslateModuleToSMTLIB(MlirModule module, MlirStringCallback callback,
void *userData, bool inlineSingleUseValues,
bool indentLetBody, bool emitReset) {
return mlirTranslateOperationToSMTLIB(
mlirModuleGetOperation(module), callback, userData, inlineSingleUseValues,
indentLetBody, emitReset);
}
3 changes: 2 additions & 1 deletion mlir/lib/Target/SMTLIB/ExportSMTLIB.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -674,7 +674,8 @@ static LogicalResult emit(SolverOp solver, const SMTEmissionOptions &options,
if (result.wasInterrupted())
return failure();

stream << "(reset)\n";
if (options.emitReset)
stream << "(reset)\n";
return success();
}

Expand Down
11 changes: 8 additions & 3 deletions mlir/test/CAPI/smt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,13 +34,18 @@ void testExportSMTLIB(MlirContext ctx) {
MlirModule module =
mlirModuleCreateParse(ctx, mlirStringRefCreateFromCString(testSMT));

MlirLogicalResult result =
mlirTranslateModuleToSMTLIB(module, dumpCallback, NULL, false, false);
(void)result;
MlirLogicalResult result = mlirTranslateModuleToSMTLIB(
module, dumpCallback, NULL, false, false, true);
assert(mlirLogicalResultIsSuccess(result));

// CHECK: ; solver scope 0
// CHECK-NEXT: (reset)

result = mlirTranslateModuleToSMTLIB(module, dumpCallback, NULL, false, false,
false);
assert(mlirLogicalResultIsSuccess(result));

// CHECK-NOT: (reset)
mlirModuleDestroy(module);
}

Expand Down