[AMDGPU] IGLP: Fix static variables (alternative to #137549)#185436
Draft
[AMDGPU] IGLP: Fix static variables (alternative to #137549)#185436
Conversation
Replace global / class-level static variables with instance members and guarantee thread-safety.
Assisted-by: claude-4.6-opus
frederik-h
requested changes
Mar 9, 2026
| // Compute the heuristics for the pipeline, returning whether or not the DAG | ||
| // is well formatted for the mutation | ||
| bool analyzeDAG(const SIInstrInfo *TII); | ||
| bool AnalysisResult; |
Contributor
There was a problem hiding this comment.
I suggest to move the member variable into a (nested) struct (similar to MFMAExpInterleaveCache from #137549 although I would not use this name here) and then change the type of this from bool to std::optional.
| ; GCN-NEXT: s_endpgm | ||
| entry: | ||
| %a = load i1, ptr %src, align 1 | ||
| call void @llvm.amdgcn.iglp.opt(i32 1) |
Contributor
There was a problem hiding this comment.
This should have a similar test case for @llvm.amdgcn.iglp.opt(i32 2)
jrbyrnes
requested changes
Mar 9, 2026
Contributor
jrbyrnes
left a comment
jrbyrnes
left a comment
There was a problem hiding this comment.
The PR should not change the semantics of the mutation / result in code changes for llvm.amdgcn.iglp.opt.exp.*.mir
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an alternative PR to #137549 that just fixes the correctness issue in the IGLP code for now, without caching.
Assisted-by: claude-4.6-opus-high