[AMDGPU] Remove extra pipes from load-saddr-offset-imm.ll - #183874
Merged
boomanaiden154 merged 1 commit intoFeb 28, 2026
Merged
Conversation
This test uses opt to run instcombin and then pipes that into llc which has its output piped into FileCheck. Before this patch, the test also piped in the source file into llc as well, which caused issues with a downstream test executor that executes the lines in bash. However, these extra pipes don't make sense anyways, so remove them.
Member
|
@llvm/pr-subscribers-backend-amdgpu Author: Aiden Grossman (boomanaiden154) ChangesThis test uses opt to run instcombin and then pipes that into llc which has its output piped into FileCheck. Before this patch, the test also piped in the source file into llc as well, which caused issues with a downstream test executor that executes the lines in bash. However, these extra pipes don't make sense anyways, so remove them. Full diff: https://github.com/llvm/llvm-project/pull/183874.diff 1 Files Affected:
diff --git a/llvm/test/CodeGen/AMDGPU/load-saddr-offset-imm.ll b/llvm/test/CodeGen/AMDGPU/load-saddr-offset-imm.ll
index fb9ed623db6c3..cc12db451c74b 100644
--- a/llvm/test/CodeGen/AMDGPU/load-saddr-offset-imm.ll
+++ b/llvm/test/CodeGen/AMDGPU/load-saddr-offset-imm.ll
@@ -1,9 +1,9 @@
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 6
-; RUN: opt -passes=instcombine < %s | llc -mtriple=amdgcn-mesa-mesa3d -mcpu=gfx1200 < %s | FileCheck -check-prefixes=GFX12,GFX12-SDAG %s
-; RUN: opt -passes=instcombine < %s | llc -mtriple=amdgcn-mesa-mesa3d -mcpu=gfx1250 < %s | FileCheck -check-prefixes=GFX1250,GFX1250-SDAG %s
-; RUN: opt -passes=instcombine < %s | llc -global-isel -mtriple=amdgcn-mesa-mesa3d -mcpu=gfx1200 < %s | FileCheck -check-prefixes=GFX12,GFX12-GISEL %s
-; RUN: opt -passes=instcombine < %s | llc -global-isel -mtriple=amdgcn-mesa-mesa3d -mcpu=gfx1250 < %s | FileCheck -check-prefixes=GFX1250,GFX1250-GISEL %s
+; RUN: opt -passes=instcombine < %s | llc -mtriple=amdgcn-mesa-mesa3d -mcpu=gfx1200 | FileCheck -check-prefixes=GFX12,GFX12-SDAG %s
+; RUN: opt -passes=instcombine < %s | llc -mtriple=amdgcn-mesa-mesa3d -mcpu=gfx1250 | FileCheck -check-prefixes=GFX1250,GFX1250-SDAG %s
+; RUN: opt -passes=instcombine < %s | llc -global-isel -mtriple=amdgcn-mesa-mesa3d -mcpu=gfx1200 | FileCheck -check-prefixes=GFX12,GFX12-GISEL %s
+; RUN: opt -passes=instcombine < %s | llc -global-isel -mtriple=amdgcn-mesa-mesa3d -mcpu=gfx1250 | FileCheck -check-prefixes=GFX1250,GFX1250-GISEL %s
; The address calculation can be simplified and folded because of known bits of mbcnt.
define amdgpu_ps <2 x float> @global_load_scale_add_foldable_knownbits(ptr addrspace(1) inreg %sbase) {
|
cmtice
approved these changes
Feb 28, 2026
boomanaiden154
enabled auto-merge (squash)
February 28, 2026 01:27
sahas3
pushed a commit
to sahas3/llvm-project
that referenced
this pull request
Mar 4, 2026
This test uses opt to run instcombin and then pipes that into llc which has its output piped into FileCheck. Before this patch, the test also piped in the source file into llc as well, which caused issues with a downstream test executor that executes the lines in bash. However, these extra pipes don't make sense anyways, so remove them.
sujianIBM
pushed a commit
to sujianIBM/llvm-project
that referenced
this pull request
Mar 5, 2026
This test uses opt to run instcombin and then pipes that into llc which has its output piped into FileCheck. Before this patch, the test also piped in the source file into llc as well, which caused issues with a downstream test executor that executes the lines in bash. However, these extra pipes don't make sense anyways, so remove them.
This was referenced Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This test uses opt to run instcombin and then pipes that into llc which has its output piped into FileCheck. Before this patch, the test also piped in the source file into llc as well, which caused issues with a downstream test executor that executes the lines in bash. However, these extra pipes don't make sense anyways, so remove them.