-
Notifications
You must be signed in to change notification settings - Fork 18.1k
[VPlan] Don't drop NUW flag on tail folded canonical IVs #183301
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
lukel97
merged 8 commits into
llvm:main
from
lukel97:loop-vectorize/dont-drop-can-iv-tail-fold
Feb 27, 2026
Merged
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
5461e50
[VPlan] Don't drop NUW flag on tail folded canonical IVs
lukel97 0dc2884
Merge branch 'main' of github.com:llvm/llvm-project into loop-vectori…
lukel97 90e8d1d
Update tests
lukel97 853c211
Sink to uses, update comment and replace with TODO to remove
lukel97 4752ae8
Update phaseordering test
lukel97 06f32d9
Merge branch 'main' into loop-vectorize/dont-drop-can-iv-tail-fold
lukel97 2598db1
Merge branch 'main' of github.com:llvm/llvm-project into loop-vectori…
lukel97 dc1f66c
Update tests after merge
lukel97 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8201,22 +8201,7 @@ VPlanPtr LoopVectorizationPlanner::tryToBuildVPlanWithVPRecipes( | |
| IVUpdateMayOverflow |= !isIndvarOverflowCheckKnownFalse(&CM, VF); | ||
|
|
||
| TailFoldingStyle Style = CM.getTailFoldingStyle(IVUpdateMayOverflow); | ||
| // Use NUW for the induction increment if we proved that it won't overflow in | ||
| // the vector loop or when not folding the tail. In the later case, we know | ||
| // that the canonical induction increment will not overflow as the vector trip | ||
| // count is >= increment and a multiple of the increment. | ||
| VPRegionBlock *LoopRegion = Plan->getVectorLoopRegion(); | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can sink this now closer to first use
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Done in 853c211 |
||
| bool HasNUW = !IVUpdateMayOverflow || Style == TailFoldingStyle::None; | ||
| if (!HasNUW) { | ||
| auto *IVInc = | ||
| LoopRegion->getExitingBasicBlock()->getTerminator()->getOperand(0); | ||
| assert(match(IVInc, | ||
| m_VPInstruction<Instruction::Add>( | ||
| m_Specific(LoopRegion->getCanonicalIV()), m_VPValue())) && | ||
| "Did not find the canonical IV increment"); | ||
| cast<VPRecipeWithIRFlags>(IVInc)->dropPoisonGeneratingFlags(); | ||
| } | ||
|
|
||
| // --------------------------------------------------------------------------- | ||
| // Pre-construction: record ingredients whose recipes we'll need to further | ||
| // process after constructing the initial VPlan. | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can also sink this and
IVUpdateMayOverflowcloser to useThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done in 853c211