[libclc] Compile with -fdenormal-fp-math=dynamic#183262
Merged
Conversation
This PR is extracted from llvm#157633. `-fdenormal-fp-math=dynamic` is required to defer denormal handling and should be used for libclc library compilation. Additionally, if the default ieee value is incompatible with the user code's denormal-fp-math setting, this mismatch prevents libclc functions from being inlined.
arsenm
approved these changes
Feb 25, 2026
Contributor
arsenm
left a comment
arsenm
left a comment
There was a problem hiding this comment.
I thought this was already done
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates libclc’s build configuration to compile builtins with -fdenormal-fp-math=dynamic, ensuring denormal handling is deferred and avoiding denormal-mode mismatches that can inhibit inlining between user code and libclc.
Changes:
- Add
-fdenormal-fp-math=dynamicto the defaultbuild_flagsused when compiling libclc sources.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is extracted from #157633.
-fdenormal-fp-math=dynamicis required to defer denormal handling and should be used for libclc library compilation.Additionally, if the default ieee value is incompatible with the user code's denormal-fp-math setting, this mismatch prevents libclc functions from being inlined.