Skip to content

[RISCV] Use getCopyFromReg in unit test to match comment. NFC #183199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
topperc merged 1 commit into from
Feb 27, 2026
Merged

[RISCV] Use getCopyFromReg in unit test to match comment. NFC #183199

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions llvm/unittests/Target/RISCV/RISCVSelectionDAGTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,10 +102,12 @@ TEST_F(RISCVSelectionDAGTest, computeKnownBits_SRLW) {
// The DAG created below is derived from this
SDLoc Loc;
auto Int64VT = EVT::getIntegerVT(Context, 64);
auto Px = DAG->getRegister(0, Int64VT);
auto Px = DAG->getCopyFromReg(DAG->getEntryNode(), Loc,

@topperc topperc Feb 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment mentioned in the title is line 94 and line 96 above.

Register::index2VirtReg(0), Int64VT);
auto Py = DAG->getConstant(2147483647, Loc, Int64VT);
auto N1 = DAG->getNode(ISD::AND, Loc, Int64VT, Px, Py);
auto Qx = DAG->getRegister(0, Int64VT);
auto Qx = DAG->getCopyFromReg(DAG->getEntryNode(), Loc,
Register::index2VirtReg(1), Int64VT);
auto N2 = DAG->getNode(RISCVISD::SRLW, Loc, Int64VT, N1, Qx);
auto Py2 = DAG->getConstant(4294967295, Loc, Int64VT);
auto N3 = DAG->getNode(ISD::AND, Loc, Int64VT, N2, Py2);
Expand Down