[amdgpu-cfi: 1/9]: [MIR] Error on signed integer in getUnsigned - #183171
Merged
slinder1 merged 1 commit intoFeb 27, 2026
Merged
Conversation
slinder1
changed the title
This was referenced Feb 24, 2026
slinder1
changed the title
slinder1
requested review from
OCHyams,
SLTozer,
adrian-prantl,
arsenm,
epilk,
jmorse and
kzhuravl
February 26, 2026 21:21
slinder1
marked this pull request as ready for review
February 26, 2026 21:22
arsenm
approved these changes
Feb 26, 2026
Previously we effectively took the absolute value of the APSInt, instead diagnose the unexpected negative value. Change-Id: I4efe961e7b29fdf1d5f97df12f8139aac12c9219
slinder1
force-pushed
the
users/slinder1/I4efe961e7b29fdf1d5f97df12f8139aac12c9219
branch
from
February 26, 2026 21:53
a6ece64 to
15f2f56
Compare
Contributor
Author
|
Changes since last push: diff --git b/llvm/test/CodeGen/MIR/Generic/expected-unsigned.mir a/llvm/test/CodeGen/MIR/Generic/expected-unsigned.mir
@@ -1,4 +1,4 @@
-# RUN: not llc -run-pass none -o /dev/null %s 2>&1 | FileCheck %s
+# RUN: not llc -run-pass=none -filetype=null %s 2>&1 | FileCheck %s
# Stand in as a test of all uses of MIParser::getUnsigned to ensure it
# rejects negative integers.
|
slinder1
deleted the
users/slinder1/I4efe961e7b29fdf1d5f97df12f8139aac12c9219
branch
February 27, 2026 14:31
sujianIBM
pushed a commit
to sujianIBM/llvm-project
that referenced
this pull request
Mar 5, 2026
Previously we effectively took the absolute value of the APSInt, instead diagnose the unexpected negative value. Change-Id: I4efe961e7b29fdf1d5f97df12f8139aac12c9219
Contributor
Author
🛠️ Changes since last push (click to expand): |
This was referenced Apr 15, 2026
Contributor
Author
|
🛠️ Changes since last push: none (likely a rebase) |
Contributor
Author
|
🛠️ Changes since last push: none (likely a rebase) |
15 similar comments
Contributor
Author
|
🛠️ Changes since last push: none (likely a rebase) |
Contributor
Author
|
🛠️ Changes since last push: none (likely a rebase) |
Contributor
Author
|
🛠️ Changes since last push: none (likely a rebase) |
Contributor
Author
|
🛠️ Changes since last push: none (likely a rebase) |
Contributor
Author
|
🛠️ Changes since last push: none (likely a rebase) |
Contributor
Author
|
🛠️ Changes since last push: none (likely a rebase) |
Contributor
Author
|
🛠️ Changes since last push: none (likely a rebase) |
Contributor
Author
|
🛠️ Changes since last push: none (likely a rebase) |
Contributor
Author
|
🛠️ Changes since last push: none (likely a rebase) |
Contributor
Author
|
🛠️ Changes since last push: none (likely a rebase) |
Contributor
Author
|
🛠️ Changes since last push: none (likely a rebase) |
Contributor
Author
|
🛠️ Changes since last push: none (likely a rebase) |
Contributor
Author
|
🛠️ Changes since last push: none (likely a rebase) |
Contributor
Author
|
🛠️ Changes since last push: none (likely a rebase) |
Contributor
Author
|
🛠️ Changes since last push: none (likely a rebase) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we effectively took the absolute value of the APSInt, instead
diagnose the unexpected negative value.
Change-Id: I4efe961e7b29fdf1d5f97df12f8139aac12c9219
Stack:
main(Note: Closed and merged PRs may not be reflected here and PR numbering is not stable.)