Skip to content

[libsycl] Add sycl::context stub - #182826

Merged
KseniyaTikhomirova merged 6 commits into
llvm:mainfrom
KseniyaTikhomirova:usm_part1_context
Feb 27, 2026
Merged

KseniyaTikhomirova merged 6 commits into
llvm:mainfrom
KseniyaTikhomirova:usm_part1_context

Conversation

@KseniyaTikhomirova

Copy link
Copy Markdown
Contributor

Part 1 of changes needed for USM alloc/dealloc impl.

This is part of the SYCL support upstreaming effort. The relevant RFCs can be found here:

https://discourse.llvm.org/t/rfc-add-full-support-for-the-sycl-programming-model/74080 https://discourse.llvm.org/t/rfc-sycl-runtime-upstreaming/74479

Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
@KseniyaTikhomirova
KseniyaTikhomirova marked this pull request as ready for review February 23, 2026 11:05
@KseniyaTikhomirova

KseniyaTikhomirova commented Feb 23, 2026

Copy link
Copy Markdown
Contributor Author

Hi @tahonermann, @dvrogozh, @sergey-semenov, @bader, @againull, @dm-vodopyanov,

PR split was requested in complete PR for USM #181120.
There is an issue with stacked PRs process, so I can't publish that PR in the view as it was requested. I am working on this in background but I have already lost a lot of time without review of these changes because if it and I don't want to lose more.

it is very important to start reviewing USM impl as it will be published as 3 PRs now. Could you please help with review?

thanks.

@KseniyaTikhomirova
KseniyaTikhomirova requested review from againull, bader and tahonermann and removed request for tahonermann February 23, 2026 11:23
@bader bader changed the title [libsycl] add sycl::context stub [libsycl] Add sycl::context stub Feb 23, 2026
Comment thread libsycl/src/detail/offload/offload_utils.hpp Outdated
Comment thread libsycl/src/device.cpp
Comment thread libsycl/src/detail/platform_impl.hpp Outdated
Comment thread libsycl/src/detail/platform_impl.hpp Outdated
Comment thread libsycl/src/detail/platform_impl.hpp Outdated
Comment thread libsycl/include/sycl/__impl/context.hpp Outdated
Comment thread libsycl/src/detail/context_impl.cpp Outdated
Comment thread libsycl/src/context.cpp
Comment thread libsycl/src/detail/context_impl.hpp Outdated
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Comment thread libsycl/src/detail/platform_impl.hpp Outdated

@bader bader left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Please, update context comment before the merge.

Comment thread libsycl/src/detail/context_impl.hpp Outdated
Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
@KseniyaTikhomirova
KseniyaTikhomirova merged commit bad56db into llvm:main Feb 27, 2026
10 checks passed
sujianIBM pushed a commit to sujianIBM/llvm-project that referenced this pull request Mar 5, 2026
Part 1 of changes needed for USM alloc/dealloc impl.


This is part of the SYCL support upstreaming effort. The relevant RFCs
can be found here:


https://discourse.llvm.org/t/rfc-add-full-support-for-the-sycl-programming-model/74080
https://discourse.llvm.org/t/rfc-sycl-runtime-upstreaming/74479

---------

Signed-off-by: Tikhomirova, Kseniya <kseniya.tikhomirova@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants