Skip to content

[LLVM][ExecutionEngine] Add vector ConstantInt/FP support to getConstantValue(). #182538

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulwalker-arm merged 3 commits into from
Feb 27, 2026
Merged

[LLVM][ExecutionEngine] Add vector ConstantInt/FP support to getConstantValue(). #182538

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
09d1d2d
Add test showing crash when vector ConstantInt/FP are in use.
paulwalker-arm Feb 20, 2026
ec2a94e
[LLVM][ExecutionEngine] Add vector ConstantInt/FP support to getConst…
paulwalker-arm Feb 20, 2026
a62541a
[LLVM][ExecutionEngine] Simplify vector constant handling.
paulwalker-arm Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 17 additions & 14 deletions llvm/lib/ExecutionEngine/ExecutionEngine.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -934,25 +934,27 @@ GenericValue ExecutionEngine::getConstantValue(const Constant *C) {
const ConstantDataVector *CDV = dyn_cast<ConstantDataVector>(C);
const ConstantVector *CV = dyn_cast<ConstantVector>(C);
const ConstantAggregateZero *CAZ = dyn_cast<ConstantAggregateZero>(C);
const ConstantInt *CI = dyn_cast<ConstantInt>(C);
const ConstantFP *CFP = dyn_cast<ConstantFP>(C);

if (CDV) {
elemNum = CDV->getNumElements();
ElemTy = CDV->getElementType();
} else if (CV || CAZ) {
} else if (CV || CAZ || CI || CFP) {
auto *VTy = cast<FixedVectorType>(C->getType());
elemNum = VTy->getNumElements();
ElemTy = VTy->getElementType();
} else {
llvm_unreachable("Unknown constant vector type!");
llvm_unreachable("Unknown constant vector type!");
}

Result.AggregateVal.resize(elemNum);
// Check if vector holds floats.
if(ElemTy->isFloatTy()) {
if (CAZ) {
GenericValue floatZero;
floatZero.FloatVal = 0.f;
llvm::fill(Result.AggregateVal, floatZero);
if (CAZ || CFP) {
GenericValue floatVal;
floatVal.FloatVal = CAZ ? 0.f : CFP->getValueAPF().convertToFloat();
llvm::fill(Result.AggregateVal, floatVal);
break;
}
if(CV) {
Expand All @@ -970,10 +972,10 @@ GenericValue ExecutionEngine::getConstantValue(const Constant *C) {
}
// Check if vector holds doubles.
if (ElemTy->isDoubleTy()) {
if (CAZ) {
GenericValue doubleZero;
doubleZero.DoubleVal = 0.0;
llvm::fill(Result.AggregateVal, doubleZero);
if (CAZ || CFP) {
GenericValue doubleVal;
doubleVal.DoubleVal = CAZ ? 0.0 : CFP->getValueAPF().convertToDouble();
llvm::fill(Result.AggregateVal, doubleVal);
break;
}
if(CV) {
Expand All @@ -991,10 +993,11 @@ GenericValue ExecutionEngine::getConstantValue(const Constant *C) {
}
// Check if vector holds integers.
if (ElemTy->isIntegerTy()) {
if (CAZ) {
GenericValue intZero;
intZero.IntVal = APInt(ElemTy->getScalarSizeInBits(), 0ull);
llvm::fill(Result.AggregateVal, intZero);
if (CAZ || CI) {
GenericValue intVal;
intVal.IntVal =
CAZ ? APInt(ElemTy->getScalarSizeInBits(), 0ull) : CI->getValue();
llvm::fill(Result.AggregateVal, intVal);
break;
}
if(CV) {
Expand Down
3 changes: 3 additions & 0 deletions llvm/test/ExecutionEngine/Interpreter/test-interp-vec-insertelement.ll
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
; RUN: %lli -jit-kind=mcjit -force-interpreter=true %s > /dev/null
; RUN: %lli -jit-kind=mcjit -force-interpreter=true -use-constant-int-for-fixed-length-splat -use-constant-fp-for-fixed-length-splat %s > /dev/null

define i32 @main() {
%v0 = insertelement <2 x i8> zeroinitializer, i8 1, i32 1
Expand Down Expand Up @@ -37,5 +38,7 @@ define i32 @main() {
%v28 = insertelement <8 x double> zeroinitializer, double 4.0, i32 4
%v29 = insertelement <16 x double> zeroinitializer, double 5.0, i32 7

%v30 = insertelement <16 x i64> splat(i64 1), i64 5, i32 7
%v31 = insertelement <16 x double> splat(double 1.0), double 5.0, i32 7
ret i32 0
}