Skip to content

[ASan] Enable __SANITIZER_DISABLE_CONTAINER_OVERFLOW__ tests#181721

Open
DanBlackwell wants to merge 1 commit intollvm:mainfrom
DanBlackwell:reenable-asan-container-overflow-tests
Open

[ASan] Enable __SANITIZER_DISABLE_CONTAINER_OVERFLOW__ tests#181721
DanBlackwell wants to merge 1 commit intollvm:mainfrom
DanBlackwell:reenable-asan-container-overflow-tests

Conversation

@DanBlackwell
Copy link
Contributor

Now that the corresponding libcxx change has landed, these tests should be passing on some platforms.

This patch re-enables them for all platforms, so that we can see which bots these do not work on and mark them unsupported accordingly.

rdar://167946476

Now that the corresponding libcxx change has landed, these tests should be passing on some platforms.

This patch re-enables them for all platforms, so that we can see which bots these do not work on and mark them unsupported accordingly.

rdar://167946476
@llvmbot
Copy link
Member

llvmbot commented Feb 16, 2026

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Dan Blackwell (DanBlackwell)

Changes

Now that the corresponding libcxx change has landed, these tests should be passing on some platforms.

This patch re-enables them for all platforms, so that we can see which bots these do not work on and mark them unsupported accordingly.

rdar://167946476


Full diff: https://github.com/llvm/llvm-project/pull/181721.diff

2 Files Affected:

  • (modified) compiler-rt/test/asan/TestCases/disable_container_overflow_checks.cpp (-2)
  • (modified) compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp (-2)
diff --git a/compiler-rt/test/asan/TestCases/disable_container_overflow_checks.cpp b/compiler-rt/test/asan/TestCases/disable_container_overflow_checks.cpp
index 9e1e4289f0317..585be8bab6876 100644
--- a/compiler-rt/test/asan/TestCases/disable_container_overflow_checks.cpp
+++ b/compiler-rt/test/asan/TestCases/disable_container_overflow_checks.cpp
@@ -11,8 +11,6 @@
 // overflow checks at compile time.
 // RUN: %clangxx_asan -D__SANITIZER_DISABLE_CONTAINER_OVERFLOW__ -O %s -o %t-no-overflow
 // RUN: %run %t-no-overflow 2>&1 | FileCheck --check-prefix=CHECK-NOCRASH %s
-//
-// UNSUPPORTED: true
 
 #include <assert.h>
 #include <stdio.h>
diff --git a/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp b/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp
index e14d946f4e810..cb771f5c95639 100644
--- a/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp
+++ b/compiler-rt/test/asan/TestCases/stack_container_dynamic_lib.cpp
@@ -19,8 +19,6 @@
 // RUN: %clangxx_asan -D__SANITIZER_DISABLE_CONTAINER_OVERFLOW__ %s -c -o %t-main.o
 // RUN: %clangxx_asan -D__SANITIZER_DISABLE_CONTAINER_OVERFLOW__ -o %t %t-main.o %t-object.o %libdl
 // RUN: %run %t 2>&1 | FileCheck --check-prefix=CHECK-NO-CONTAINER-OVERFLOW %s
-//
-// UNSUPPORTED: true
 
 #include <assert.h>
 #include <sanitizer/common_interface_defs.h>

@DanBlackwell
Copy link
Contributor Author

Note:

Tests were disabled here: #168821
livcxx support was added here: #168955

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments